Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Tabs - Remove 'Share' When KEESHARE Is Disabled? #3619

Closed
0pLuS0 opened this issue Oct 11, 2019 · 1 comment
Closed

Group Tabs - Remove 'Share' When KEESHARE Is Disabled? #3619

0pLuS0 opened this issue Oct 11, 2019 · 1 comment

Comments

@0pLuS0
Copy link

0pLuS0 commented Oct 11, 2019

Summary

I've come to realize that when KEESHARE is disabled at compile time, that for the Groups the Share tab is still appearing.

-DWITH_XC_KEESHARE=OFF
-DWITH_XC_KEESHARE_SECURE=OFF

Desired Behavior

Please have the Share tab removed when the KEESHARE feature is disabled at compile time.

Context

Isn't it nice to not have things appear that don't work, serve no purpose? This seems more like a BUG then a Feature Request, but I'm making this as a Feature Request for now.

Please see the attached screen shot that shows the Share tab in 2.4.3 when I disabled both the KEESHARE and KEESHARE_SECURE at compile time.

share_tab

THANKS
@0pLuS0 0pLuS0 mentioned this issue Oct 12, 2019
Closed
schlimmchen pushed a commit to schlimmchen/keepassxc that referenced this issue Oct 22, 2019
no "Share" tab without WITH_XC_KEESHARE
449b748 
if KeePassXC is compiled with WITH_XC_KEESHARE=OFF, the "Share" tab of
the EntryPreviewWidget for groups is removed from the GUI completely.

closes keepassxreboot#3619.
@schlimmchen schlimmchen mentioned this issue Oct 22, 2019
Merged
schlimmchen added a commit to schlimmchen/keepassxc that referenced this issue Oct 22, 2019
@schlimmchen
no "Share" tab without WITH_XC_KEESHARE
191e8ec 
if KeePassXC is compiled with WITH_XC_KEESHARE=OFF, the "Share" tab of
the EntryPreviewWidget for groups is removed from the GUI completely.

closes keepassxreboot#3619.
schlimmchen added a commit to schlimmchen/keepassxc that referenced this issue Oct 22, 2019
@schlimmchen
no "Share" tab without WITH_XC_KEESHARE
1577286 
if KeePassXC is compiled with WITH_XC_KEESHARE=OFF, the "Share" tab of
the EntryPreviewWidget for groups is removed from the GUI completely.

closes keepassxreboot#3619.
schlimmchen added a commit to schlimmchen/keepassxc that referenced this issue Oct 22, 2019
@schlimmchen
no "Share" tab without WITH_XC_KEESHARE
86d34c9 
if KeePassXC is compiled with WITH_XC_KEESHARE=OFF, the "Share" tab of
the EntryPreviewWidget for groups is removed from the GUI completely.

closes keepassxreboot#3619.
droidmonkey pushed a commit to schlimmchen/keepassxc that referenced this issue Oct 23, 2019
@schlimmchen @droidmonkey
no "Share" tab without WITH_XC_KEESHARE
60f02a2 
if KeePassXC is compiled with WITH_XC_KEESHARE=OFF, the "Share" tab of
the EntryPreviewWidget for groups is removed from the GUI completely.

closes keepassxreboot#3619.
@0pLuS0
Copy link
Author

0pLuS0 commented Oct 30, 2019 •
edited
Loading

If anyone for any reason wants, or is still using 2.4.3 I made a patch to remove the Share Tabs based off the last commit 60f02a2.

https://gist.github.com/0pLuS0/9dac22f06025bd6984aee3edc3188473

Enjoy! :)

P.S. I did apply and test it, it's working!

scoroi pushed a commit to scoroi/keepassxc that referenced this issue Nov 10, 2019
@schlimmchen @scoroi
no "Share" tab without WITH_XC_KEESHARE
8a6a641 
if KeePassXC is compiled with WITH_XC_KEESHARE=OFF, the "Share" tab of
the EntryPreviewWidget for groups is removed from the GUI completely.

closes keepassxreboot#3619.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0pLuS0