downloading favicon shows progress bar twice #2265
Comments
|
Please don't delete the issue template. Paste your debug info from the about dialog. |
|
sorry about that. KeePassXC - Version 2.3.4 Libraries:
Operating system: Windows 10 (10.0) Enabled extensions:
Doesn't matter if favicon is successfully downloaded or not, a progress bar window pops up as if the download is starting but just shows 0% and never goes away. Also sometimes when I click "download favicon", the progress bar shows but shows 0% and hangs, but then I click "cancel" the favicon is downloaded(???). Then after I click ok to close the edit window, the download favicon progress bar pops up again and hangs at 0%. |
|
This happens for me also KeePassXC - Version 2.3.4 Libraries:
Operating system: OS X El Capitan (10.11) Enabled extensions:
|
|
Do you have that "google as fall-back" option checked? I think that is causing this issue. But if i uncheck the option I can't download any icon. Every website just returns the error "unable to fetch icon". |
|
No, I don't have it checked, and the download works for me. I only get "unable to fetch icon" when the icon is not at /favicon.ico, I guess that is expected :) |
|
When the "Google as fallback" option is checked, I even get three popups:
|
|
Same issue on my platform. KeePassXC - Version 2.3.4 Libraries:
Operating system: Linux Mint 18.3 Enabled extensions:
|
|
As @Olfrix points out, this isn't isolated to windows. I can confirm this is occurring on Linux as well. Sometimes I get multiple popup windows, other times I get a Download Progress popup that is stuck at 1%. I also have the
KeePassXC - Version 2.3.4 Libraries:
Operating system: Ubuntu Core 18 Enabled extensions:
|
|
I thought I had fixed this when I also fixed the associated crash this caused. Unfortunately, looks like there is still a race condition that occurs. The dialogs should have an update timeout that autocloses them. |
|
@droidmonkey it seems that |
Name the UrlFetchProgressDialog() with the corresponding URL in order to be identified by name by its parent when the failed request is handeled in EditWidgetIcons::fetchFinished(). fetchFinished() retrieves the relevant UrlFetchProgressDialog() and calls close() on it. Fixes: keepassxreboot#2265
Name the UrlFetchProgressDialog() with the corresponding URL in order to be identified by name by its parent when the failed request is handeled in EditWidgetIcons::fetchFinished(). fetchFinished() retrieves the relevant UrlFetchProgressDialog() and calls close() on it. Fixes: keepassxreboot#2265
Name the UrlFetchProgressDialog() with the corresponding URL in order to be identified by name by its parent when the failed request is handeled in EditWidgetIcons::fetchFinished(). fetchFinished() retrieves the relevant UrlFetchProgressDialog() and calls close() on it. Fixes: keepassxreboot#2265
…er (#2309) * Replace Google with DuckDuckGo for optional fallback favicon fetch URL Modify the work initially done in #36, and most recently modified in #1786, to use DuckDuckGo's https://icons.duckduckgo.com/ip3/www.example.com.ico favicon endpoint. Fixes #2258 * Close failed favicon fetch progress bars Name the UrlFetchProgressDialog() with the corresponding URL in order to be identified by name by its parent when the failed request is handeled in EditWidgetIcons::fetchFinished(). fetchFinished() retrieves the relevant UrlFetchProgressDialog() and calls close() on it. Fixes: #2265
When I click on the download favicon button, it either says failed to download or download instantly, but in either case a progress bar window then shows up and get stuck at 0% or 1% and doesn't go away on its own and I have to click cancel. Happening for every website.
The text was updated successfully, but these errors were encountered: