Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOTP: implement other RFC6238 HMAC algorithms #1566

Closed
tycho opened this issue Feb 28, 2018 · 0 comments · Fixed by #2972
Closed

TOTP: implement other RFC6238 HMAC algorithms #1566

tycho opened this issue Feb 28, 2018 · 0 comments · Fixed by #2972

Comments

@tycho
Copy link
Contributor

tycho commented Feb 28, 2018

Currently KeePassXC only supports the SHA-1 HMAC algorithm for TOTP codes. This is fine for 99.9% of use cases, but there -are- some services out there that use SHA-256 or even SHA-512 for HMAC. Would be nice to have those as a selectable option.
BryanJacobs added a commit to BryanJacobs/keepassxc that referenced this issue Apr 10, 2019
@BryanJacobs
Support for RFC-compliant TOTP hashes keepassxreboot#873 keepassxrebo…
1162bbe 
…ot#1566

This implements support for SHA-256 and SHA-512 hash algorithms when
generating TOTP codes. These algorithms are specified by RFC6238. The
implementation is compatible with Google's OTP URL format, as well as
with the KeeOTP plugin for KeePass.

The implementation is not wired into the GUI, as the main project
developer expressed strong negative sentiment about adding more
options there. It is possible to configure codes by putting the
appropriate string into the entry's otp property, or using another
program with a less opinionated UI and a compatible on-disk format.
@BryanJacobs BryanJacobs mentioned this issue Apr 10, 2019
Merged
droidmonkey pushed a commit that referenced this issue Apr 15, 2019
@BryanJacobs @droidmonkey
Support for RFC-compliant TOTP hashes #873 #1566
04983ce 
This implements support for SHA-256 and SHA-512 hash algorithms when
generating TOTP codes. These algorithms are specified by RFC6238. The
implementation is compatible with Google's OTP URL format, as well as
with the KeeOTP plugin for KeePass.

The implementation is not wired into the GUI, as the main project
developer expressed strong negative sentiment about adding more
options there. It is possible to configure codes by putting the
appropriate string into the entry's otp property, or using another
program with a less opinionated UI and a compatible on-disk format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for RFC-compliant TOTP hashes BryanJacobs/keepassxc
2 participants
@tycho @TheZ3ro