Password is not copied when other text is selected in KeePassXC #10734
Comments
|
I have the same issue, I can not copy any kind of passwords from Keepass since yesturday. I have even updated to the latest version. I can not even copy the debug info, none of the copy methods works in the app. I can only use the auto typer. App version |
|
Update: Tested Version 2.7.7 on the same system using the same extensions, and still no copy. The 2.7.6 works. |
SummarySame here on linux as well. It seems to be a cross platform issue. Debug InformationSystem InformationWorkaround
|
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 2, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Fixes keepassxreboot#10734.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 3, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Fixes keepassxreboot#10734.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 6, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734. Also, relatedly: - Change the global ActionCollection object to be owned by the global MainWindow object, instead of being a singleton. This clarifies the fact that it represents the set of actions that belong to the main window. - Change the ActionCollection API to support adding an action and setting a default keyboard shortcut for it at the same time. In MainWindow, take advantage of that to eliminate some repeated mentions of each action. - Other small changes to the ActionCollection API. - Minor code cleanups.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 6, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734. Also, relatedly: - Change the global ActionCollection object to be owned by the global MainWindow object, instead of being a singleton. This clarifies the fact that it represents the set of actions that belong to the main window. - Change the ActionCollection API to support adding an action and setting a default keyboard shortcut for it at the same time. In MainWindow, take advantage of that to eliminate some repeated mentions of each action. - Other small changes to the ActionCollection API. - Change ActionCollection to store the default keyboard shortcut for each action in a map (QHash) instead of a property on the QAction. This seemed to be a bit nicer (and typesafe) since we had to introduce this map for another reason (i.e. to store the set of QShortcut instances in case the action had a shortcut that clashes with the system copy action). - Minor code cleanups.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 6, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734. Also, relatedly: - Change the global ActionCollection object to be owned by the global MainWindow object, instead of being a singleton. This clarifies the fact that it represents the set of actions that belong to the main window. - Change the ActionCollection API to support adding an action and setting a default keyboard shortcut for it at the same time. In MainWindow, take advantage of that to eliminate some repeated mentions of each action. - Other small changes to the ActionCollection API. - Change ActionCollection to store the default keyboard shortcut for each action in a map (QHash) instead of a property on the QAction. This seemed to be a bit nicer (and typesafe) since we had to introduce this map for another reason (i.e. to store the set of QShortcut instances in case the action had a shortcut that clashes with the system copy action). - Minor code cleanups.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 6, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734. Also, relatedly: - Change the global ActionCollection object to be owned by the global MainWindow object, instead of being a singleton. This clarifies the fact that it represents the set of actions that belong to the main window. - Change the ActionCollection API to support adding an action and setting a default keyboard shortcut for it at the same time. In MainWindow, take advantage of that to eliminate some repeated mentions of each action. - Other small changes to the ActionCollection API. - Change ActionCollection to store the default keyboard shortcut for each action in a map (QHash) instead of a property on the QAction. This seemed to be a bit nicer (and typesafe) since we had to introduce this map for another reason (i.e. to store the set of QShortcut instances in case the action had a shortcut that clashes with the system copy action). - Minor code cleanups.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 7, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734. Also, relatedly: - Change the global ActionCollection object to be owned by the global MainWindow object, instead of being a singleton. This clarifies the fact that it represents the set of actions that belong to the main window. - Change the ActionCollection API to support adding an action and setting a default keyboard shortcut for it at the same time. In MainWindow, take advantage of that to eliminate some repeated mentions of each action. - Other small changes to the ActionCollection API. - Change ActionCollection to store the default keyboard shortcut for each action in a map (QHash) instead of a property on the QAction. This seemed to be a bit nicer (and typesafe) since we had to introduce this map for another reason (i.e. to store the set of QShortcut instances in case the action had a shortcut that clashes with the system copy action). - Minor code cleanups.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 11, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 11, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 13, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 13, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 13, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734.
c4rlo
added a commit
to c4rlo/keepassxc
that referenced
this issue
Jun 16, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Add a test case to TestGui.cpp. Fixes keepassxreboot#10734.
droidmonkey
added a commit
that referenced
this issue
Jun 19, 2024
When the user chooses to copy the password for an entry to the clipboard, previously there was logic to check if text was selected, and if so, that text was instead copied to the clipboard. That made sense if (a) the user invoked the Copy Password action via its keyboard shortcut, and (b) that keyboard shortcut was configured (as per default) to be Ctrl-C, i.e. the same as the system action for copy-to-clipboard. However, it made no sense if the user invoked that action in some other way, for example by clicking the corresponding toolbar button. It also made no sense in the case that the Copy Password action had some other keyboard shortcut assigned. Also, if some other action had Ctrl-C assigned, the logic would not kick in then. Fix all of the above by modifying the keyboard shortcut logic to intervene precisely in the case where a shortcut is pressed that matches the system copy-to-clipboard shortcut; only in that case do we now check if text is selected and if so copy that to the clipboard instead of the action we would otherwise take. Fixes #10734.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Looks like with selected text "Copy username" and "Copy URL" buttons works correctly, but not "Copy password" button.
Steps to Reproduce
For the attached screenshot:
Expected Behavior
The password value is copied (here "Password").
Actual Behavior
The selected text is copied (here "Description").
Context
The text was updated successfully, but these errors were encountered: