Added a confirmation dialog

keepassxreboot · Mar 16, 2019 · f401a7f · f401a7f
1 parent 5470c0e
commit f401a7f
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/src/browser/BrowserService.cpp b/src/browser/BrowserService.cpp
@@ -200,6 +200,13 @@ QJsonObject BrowserService::getDatabaseGroups()
 
 QJsonObject BrowserService::createNewGroup(const QString& groupName)
 {
+    QJsonObject result;
+    if (thread() != QThread::currentThread()) {
+        QMetaObject::invokeMethod(this, "createNewGroup", Qt::BlockingQueuedConnection,
+            Q_RETURN_ARG(QJsonObject, result), Q_ARG(QString, groupName));
+        return result;
+    }
+
     auto db = getDatabase();
     if (!db) {
         return {};
@@ -210,7 +217,6 @@ QJsonObject BrowserService::createNewGroup(const QString& groupName)
         return {};
     }
 
-    QJsonObject result;
     auto group = rootGroup->findGroupByPath(groupName);
 
     // Group already exists
@@ -220,6 +226,16 @@ QJsonObject BrowserService::createNewGroup(const QString& groupName)
         return result;
     }
 
+    auto dialogResult = MessageBox::warning(nullptr,
+                                            tr("KeePassXC: Create a new group"),
+                                            tr("A request for creating a new group \"%1\" has been received.\n"
+                                               "Do you want to create this group?\n").arg(groupName),
+                                            MessageBox::Yes | MessageBox::No);
+
+    if (dialogResult != MessageBox::Yes) {
+        return result;
+    }
+
     QString name, uuid;
     Group* previousGroup = rootGroup;
     auto groups = groupName.split("/");