-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passkey improvements #2121
Passkey improvements #2121
Conversation
Need to also add an https/certificate validity check if that is possible. See #2122 |
I cannot get the Microsoft Passkeys creation to work with Firefox (macOS). It always popups the OS' own Passkeys prompt instead. I thought it might be related to this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1878598 but after setting that option to false, I get a different prompt from Firefox. I'm still trying to disable few other options too and see if it helps. EDIT: Nope. |
c6c056e
to
f6ea29d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm still going through the corresponding KeePassXC changes (I've just gotten through the create credentials flow, still have get to go), but I spotted some issues and some things I'm not sure about in this PR.
bb0d98d
to
6aa8c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just spotted one redundant if condition in your changes.
df36cd0
to
f6e2a86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a final approval, works great
Makes some improvements to the Passkeys implementation:
sameOriginWithAncestors
. If the origin does not match, the request are ignored.Corresponding KeePassXC side PR: keepassxreboot/keepassxc#10318