Bump cairo-vm #386
Merged
Bump cairo-vm #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftheirs
approved these changes
Sep 26, 2024
HermanObst
approved these changes
Sep 26, 2024
Collaborator
HermanObst
left a comment
HermanObst
left a comment
There was a problem hiding this comment.
LGTM
Just some questions to clarify
| /// Convert the base64 encoding of the pie to an unzipped folder. | ||
| pub fn decode_base64_to_unzipped(pie_str: &str, dst: &str) -> Result<(), SnOsError> { | ||
| let buffer = | ||
| general_purpose::STANDARD.decode(pie_str.as_bytes()).map_err(|e| SnOsError::PieZipping(format!("{e}")))?; |
| cairo-lang-casm = { version = "=2.8.2" } | ||
| cairo-type-derive = { version = "0.1.0", path = "crates/cairo-type-derive" } | ||
| cairo-vm = { git = "https://github.com/Moonsong-Labs/cairo-vm", rev = "56b68b50944ecb3123a168218ea7b8b8e23f9be8", features = ["cairo-1-hints", "extensive_hints", "mod_builtin"] } | ||
| cairo-vm = { git = "https://github.com/Moonsong-Labs/cairo-vm", branch = "notlesh/segment-arena-relocation-fix", features = ["cairo-1-hints", "extensive_hints", "mod_builtin"] } |
Collaborator
There was a problem hiding this comment.
Did you bump this branch to cairo-vm latest?
@notlesh
Contributor
Author
There was a problem hiding this comment.
Yes, the change here basically does:
- undo the previous hack mentioned in the PR description (by not including the commit 56b68b5)
- include
merge mainwhich pulls in the upstream fix (also mentioned in the PR desc)
Contributor
|
I'll wait for this PR before raising mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump
cairo-vmto latestmain.This also required bumping
cairoto2.8.2which required bumping ourrustcversion.This pulls in an upstream fix which makes this hack obsolete.
Issue Number: N/A
Type
Breaking changes?