Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Add TraceTransaction RPC call implementation #1455

Merged
merged 52 commits into from
Apr 8, 2024

Conversation

Tbelleng
Copy link
Contributor

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature

What is the current behavior?

I implemented TraceTransaction by using the model provided by TraceBlockTx.
In this implementation, i build the block until i find the tx_hash that im looking for, in order to avoid a complete block execution as TraceBlockTx already did.

Resolves: #1367

What is the new behavior?

Implement TraceTransaction RPC call method

Does this introduce a breaking change?

No

Other information

@tdelabro tdelabro self-requested a review February 21, 2024 11:28
crates/client/rpc/src/trace_api.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/trace_api.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/trace_api.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/trace_api.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/trace_api.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/trace_api.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/runtime_api/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/runtime_api/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need RPC tests

crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/trace_api.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/trace_api.rs Outdated Show resolved Hide resolved
@apoorvsadana
Copy link
Collaborator

@Tbelleng are you still working on fixing the test cases?

@tdelabro tdelabro merged commit 7d3ba01 into keep-starknet-strange:main Apr 8, 2024
13 of 14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(rpc): Implement starknet_traceTransaction RPC call
4 participants