This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 293
Add TraceTransaction RPC call implementation #1455
Merged
tdelabro
merged 52 commits into
keep-starknet-strange:main
from
Tbelleng:feat/trace_tx_v1
Apr 8, 2024
Merged
Add TraceTransaction RPC call implementation #1455
tdelabro
merged 52 commits into
keep-starknet-strange:main
from
Tbelleng:feat/trace_tx_v1
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/trace_transaction
…into feat/trace_tx_v1
tdelabro
suggested changes
Feb 21, 2024
tdelabro
force-pushed
the
feat/trace_tx_v1
branch
from
February 21, 2024 13:14
3c1ed4a
to
7ee3c0b
Compare
Tbelleng
force-pushed
the
feat/trace_tx_v1
branch
from
February 22, 2024 17:01
7ee3c0b
to
97e26c4
Compare
tdelabro
suggested changes
Feb 23, 2024
tdelabro
suggested changes
Feb 23, 2024
tdelabro
suggested changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need RPC tests
tdelabro
suggested changes
Mar 4, 2024
…into feat/trace_tx_v1
@Tbelleng are you still working on fixing the test cases? |
apoorvsadana
approved these changes
Apr 8, 2024
antiyro
approved these changes
Apr 8, 2024
tdelabro
approved these changes
Apr 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
I implemented TraceTransaction by using the model provided by TraceBlockTx.
In this implementation, i build the block until i find the tx_hash that im looking for, in order to avoid a complete block execution as TraceBlockTx already did.
Resolves: #1367
What is the new behavior?
Implement TraceTransaction RPC call method
Does this introduce a breaking change?
No
Other information