Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_owner_or_member_of_profile function and is_member_of_profile function #46

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Manush-2005
Copy link
Contributor

This PR introduces an new function is_owner_or_member_of_profile.

This function will check if the given address is owner or member of the profile.

Fixes #10

The above issue was dependent on another function is_member_of_profile

This function will check if the given address is member of the profile.

So fixed #5 in the process.

@Manush-2005
Copy link
Contributor Author

A quick ping on this PR @Akashneelesh

@Akashneelesh
Copy link
Collaborator

Akashneelesh commented Sep 3, 2024

Please comment under the issue and only pick it up ones you've been assigned to issue. And avoid redundant PR raise for the same issue. Please fix the issue -> do scarb fmt before raising PR and fix the error while trying to do snforge test

Here's where most of the communication is done : https://t.me/starknetindia

@Akashneelesh Akashneelesh reopened this Sep 3, 2024
@Manush-2005
Copy link
Contributor Author

Hey @Akashneelesh , sorry that I didn't communicate well with the fellow contributors. I executed the snforge fmt command as you said.

@Manush-2005
Copy link
Contributor Author

Manush-2005 commented Sep 3, 2024

Also, snforge tests are failing for me. I think there is an problem with snforge that github workflow is using and the toml file.

Edited:
I was trying to test my branch but test are not running.(Using scarb 0.26.3 and snforge 0.23.0)

WhatsApp Image 2024-09-05 at 18 06 42_60e44d35

@Akashneelesh
Copy link
Collaborator

Akashneelesh commented Sep 10, 2024

Hello @Manush-2005 , looks like the build is failing for some reason. I think its an issue from my side in terms of the CI

@Manush-2005
Copy link
Contributor Author

Hey @Akashneelesh , just ran scarb build again to check and the build was successful

@Manush-2005
Copy link
Contributor Author

Hey @Akashneelesh, just a quick a ping on this issue.

@Manush-2005
Copy link
Contributor Author

Hey @Akashneelesh , quick ping on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants