Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update databricks deployment docs and remove mentions of custom entrypoint #4067

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Aug 6, 2024

Description

Update Databricks deployment docs now the __main__.py has been updated: #4026

Development notes

Note

I'll update the databricks-iris starter in a follow up PR

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@merelcht merelcht changed the title Update databricks deployment docs and remove mentions of custom entry… Update databricks deployment docs and remove mentions of custom entrypoint Aug 6, 2024
@merelcht merelcht self-assigned this Aug 6, 2024
@merelcht merelcht marked this pull request as ready for review August 6, 2024 11:54
@merelcht merelcht requested review from noklam, ankatiyar and ElenaKhaustova and removed request for astrojuanlu and yetudada August 6, 2024 11:54
@noklam
Copy link
Contributor

noklam commented Aug 6, 2024

@JenspederM After this we no longer need a custom entrypoint for Databricks, and this would have the full argument list as kedro run.

Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️ Happy to see the custom entrypoints get deleted!

@merelcht merelcht linked an issue Aug 7, 2024 that may be closed by this pull request
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@merelcht merelcht enabled auto-merge (squash) August 9, 2024 09:34
@merelcht merelcht merged commit d5916a1 into main Aug 9, 2024
10 checks passed
@merelcht merelcht deleted the docs/update-databricks-deployment-doc-entrypoint branch August 9, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaged kedro pipeline does not work well on Databricks
3 participants