Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Kedro-Viz in VSCode Kedro extension #2078

Merged
merged 9 commits into from
Sep 11, 2024
Merged

Documentation: Kedro-Viz in VSCode Kedro extension #2078

merged 9 commits into from
Sep 11, 2024

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Sep 5, 2024

Description

Resolves kedro-org/vscode-kedro#89

Development notes

  • Updated README.md
  • Updated kedro-viz_visualisation.md

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

jitu5 added 3 commits September 5, 2024 10:21
@jitu5
Documentation: Kedro-Viz in VSCode
33e5327 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5
Missing gif added
4918c00 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5
Update README.md
693e03e 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@astrojuanlu
Copy link
Member

RTD build failing

sphinx.errors.SphinxWarning: /home/docs/checkouts/readthedocs.org/user_builds/kedro-viz/checkouts/2078/docs/source/kedro-viz_visualisation.md:250:broken link: https://github.com/kedro-org/vscode-kedro?tab=readme-ov-file#how-to-use-this-extension (Anchor 'how-to-use-this-extension' not found)

@jitu5
Link updated
28e3d0f 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 self-assigned this Sep 5, 2024
astrojuanlu
astrojuanlu approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👏🏼

@jitu5 @rashidakanchwala
Update docs/source/kedro-viz_visualisation.md
9a0f889 
Co-authored-by: rashidakanchwala <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 merged commit aefe8c5 into main Sep 11, 2024
40 checks passed
@jitu5 jitu5 deleted the docs/vscode branch September 11, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noklam noklam noklam approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@ravi-kumar-pilla ravi-kumar-pilla Awaiting requested review from ravi-kumar-pilla

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

Assignees

@jitu5 jitu5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Kedro-Viz in VSCode Kedro extension
5 participants
@jitu5 @astrojuanlu @noklam @rashidakanchwala @ravi-kumar-pilla