-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce metadataPanel
prop in Kedro-Viz react component
#1965
Conversation
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Co-authored-by: rashidakanchwala <[email protected]> Signed-off-by: Jitendra Gundaniya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment on the behavior.
Signed-off-by: Jitendra Gundaniya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks :)
Hi @jitu5 , I am testing the PR and it hides the metadata panel based on the display flag. I found a minor issue which seems to be present in demo site as well. Wanted to confirm if it is an expected behavior. Steps taken -
Thank you |
Hi @jitu5 , I understand we are not showing the metadata panel based on the display flag but I think we should still honour the stateful URL. As of now, when I click on a node, the selected node id (sid) seems missing in the URL. Thank you |
Signed-off-by: Jitendra Gundaniya <[email protected]>
@ravi-kumar-pilla Now url is updating. thanks. |
@ravi-kumar-pilla I think it is right behaviour, here we wanted to select other node by expanding/clicking a modular pipeline and still keeping selected node active. |
Signed-off-by: Jitendra Gundaniya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, thank you @jitu5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @jitu5
Closing this PR as it already merged with #1992 to |
Resolves #1745
This PR addresses a requirement for cases where users of Kedro-Viz as a React component in embedded mode want to hide metadata panel.
<KedroViz display={{metadataPanel: false}} data={json} />
Below is the metadata panel which will be visible when user clicks on node.
Note: When user set
metadataPanel
tofalse
, nothing will happen when user clicks on node.Checklist
RELEASE.md
file