-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Kedro 19 #1680
Support for Kedro 19 #1680
Conversation
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
…ro-viz into fix/kedro19-compat Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
…ro-viz into fix/kedro19-compat Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one minor suggestion around using kedro-datasets
2.0.0 in the demo project, but otherwise looks great! 🎉
@@ -1,4 +1,4 @@ | |||
kedro~=0.18.0 | |||
kedro>=0.18.0 | |||
kedro-datasets[pandas.CSVDataSet,pandas.ExcelDataSet, pandas.ParquetDataSet, plotly.PlotlyDataSet, matplotlib.MatplotlibWriter]~=1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to use kedro-datasets
2.0.0 if possible for the demo project so it's on the very latest release.
kedro-datasets[pandas.CSVDataSet,pandas.ExcelDataSet, pandas.ParquetDataSet, plotly.PlotlyDataSet, matplotlib.MatplotlibWriter]~=1.0 | |
kedro-datasets[pandas.CSVDataset,pandas.ExcelDataset, pandas.ParquetDataset, plotly.PlotlyDataset, matplotlib.MatplotlibWriter]~=2.0 |
Description
Development notes
kedro run
might not work on demo-project and needs more refactoring)kedro.framework.cli.utils
)kedro.io.core
spaceflights-pandas
for latest version of kedrocatalog._datasets
--params
tokedro viz run
using=
as mentioned hereQA notes
conda create --name <env_name> python=3.8
or clean old env requirements usingpip uninstall -y -r <(pip freeze)
pip install -r package/test_requirements.txt -r demo-project/src/docker_requirements.txt
make build
pip install -e package
cd demo-project
kedro viz run
Checklist
RELEASE.md
file