Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move development requirements #238

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ElenaKhaustova
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova commented Sep 19, 2024

Motivation and Context

Solves kedro-org/kedro#2519

For each starter we moved development dependencies from requirements.txt to the [project.optional-dependencies][dev] section the the pyproject.toml

Corresponding docs update: kedro-org/kedro#4178

How has this been tested?

  1. Create a starter
  2. In the project root run
  • pip install . - should install only requirements from requirements.txt
  • pip install ."[dev]" - should install requirements from the pyproject.toml (dev section in the [project.optional-dependencies])

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: Elena Khaustova <[email protected]>
Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ElenaKhaustova ! Will be the same change in the kedro project template?

@ElenaKhaustova
Copy link
Contributor Author

Thanks, @ElenaKhaustova ! Will be the same change in the kedro project template?

Yes, that's a good catch!

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ElenaKhaustova!!

@ElenaKhaustova ElenaKhaustova merged commit a0fc40c into main Sep 20, 2024
33 checks passed
@ElenaKhaustova ElenaKhaustova deleted the feature/2519-move-dev-requirements branch September 20, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants