add the jupyter dependencies into starter #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <[email protected]>
8 tasks
merelcht
approved these changes
Aug 6, 2024
ankatiyar
reviewed
Aug 16, 2024
| @@ -2,6 +2,7 @@ ipython>=8.10 | |||
| jupyterlab>=3.0 | |||
| notebook | |||
| kedro~={{ cookiecutter.kedro_version }} | |||
| kedro[jupyter] | |||
There was a problem hiding this comment.
Would it make sense to update the line above to kedro[jupyter]~={{ cookiecutter.kedro_version }} itself?
There was a problem hiding this comment.
I thought about this, but then decide to do this because Jupyter is usually not a mandatory requirement so people can remove it easily. (So i expect people can delete this line or move it to a dev-requirements.txt easily).
They are equivalent so I don't have strong opinion, which one do you prefer?
There was a problem hiding this comment.
I don't feel strongly either tbh and that makes sense ^
noklam
requested review from
lrcouto and
ankatiyar
and removed request for
ElenaKhaustova
ankatiyar
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Part of #3643
This is equivalent to add
ipylabinto starter as it is the only dependency we have. We addkedro[jupyter]as this is maintained from thekedroside already.