Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document SESSION_STORE_ARGS as optional in starter project settings #225

Merged
merged 14 commits into from
Aug 8, 2024
Merged

Document SESSION_STORE_ARGS as optional in starter project settings #225

merged 14 commits into from
Aug 8, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Jul 2, 2024 •
edited
Loading

Motivation and Context

Resolves kedro-org/kedro-viz#1951

This is a documentation update for the PR - kedro-org/kedro-viz#1915

NOTE: Kedro-Viz had a bug in handling the parent directory creation for default session_store path. The tests in this PR are failing due to the same issue. We should merge this PR after the new release of Kedro-Viz which has the bug fix.

ValueError: 
(sqlite3.OperationalError) unable to open database file
(Background on this error at: https://sqlalche.me/e/20/e3q8).
Failed to instantiate session store of type 
'kedro_viz.integrations.kedro.sqlite_store.SQLiteStore'.

How has this been tested?

  • Documentation for user reference in the starters

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review August 5, 2024 21:39
@ravi-kumar-pilla ravi-kumar-pilla requested review from rashidakanchwala, merelcht and noklam and removed request for merelcht August 5, 2024 21:39
@ravi-kumar-pilla ravi-kumar-pilla merged commit 4368583 into main Aug 8, 2024
23 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the chore/remove-session-args branch August 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noklam noklam noklam approved these changes

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing SESSION_STORE_ARGS default from starters
3 participants
@ravi-kumar-pilla @noklam @rashidakanchwala