-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tools e2e tests to kedro-starters #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo all tests passing 🥳 I'm happy with these tests being here instead of kedro
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Should we add nightly/maybe less frequent builds here as well? Since PRs on |
Yes that's a good idea. Nightly seems like a good cadence and that's the same as we do for the plugins right? |
Thank you, @SajidAlamQB, for trying various methods to solve that issue. I have a query regarding the separation of tests from our main repository to the starters repository: would it make sense to initiate a check of the starters repository whenever a pull request is made on the main repository? Is such an integration feasible as a part of check on main repo before allowing merge? |
It definitely should be I believe we do it for viz. |
Adding these tests has increased the runtime by ~7 minutes. |
Motivation and Context
related to: kedro-org/kedro#3518
After discussing with @merelcht, we've concluded that it would be better to relocate some of the e2e tests for
tools
to thekedro-starters
repository. This decision follows a recent update in Kedro, which ensures that the example starters pulled viatools
will always match the current version ofKedro
. This change has inadvertently led to release delays, askedro-starters
are released after akedro
.To solve this issue, we moved/copied some of the tests to
kedro-starters
. However, this does means that we will no longer run the pipelines withinKedro
for the--tools
e2e tests. instead, these tests will occur in the starters repository. Given all this we still think its necessary for smoother release processes.Would love to get everyone's input on this. @merelcht, @AhdraMeraliQB, @ankatiyar, @noklam, @DimedS, @lrcouto.
Checklist