Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert kedro-viz pin to release version #193

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Revert kedro-viz pin to release version #193

merged 1 commit into from
Dec 5, 2023

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Dec 5, 2023

Motivation and Context

Context: #161

This should stop our e2e tests from breaking on the develop branch of kedro. After a new commit to kedro-viz that pinned s3fs it became incompatible with kedro-datasets which some of our tools rely on. We need to change the pin of kedro-viz to a release version again instead of the main branch to fix it.

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: SajidAlamQB <[email protected]>
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SajidAlamQB

@SajidAlamQB SajidAlamQB enabled auto-merge (squash) December 5, 2023 17:36
Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SajidAlamQB !

@SajidAlamQB SajidAlamQB merged commit cc40c09 into main Dec 5, 2023
36 checks passed
@SajidAlamQB SajidAlamQB deleted the fix-viz-pin branch December 5, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants