Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github actions migration (2nd attempt) #190

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Github actions migration (2nd attempt) #190

merged 7 commits into from
Dec 1, 2023

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Nov 30, 2023 •
edited
Loading

Motivation and Context

Fix kedro-org/kedro#3207

How has this been tested?

  • Port all tests to GHA (PySpark starter tests are working now thanks to @SajidAlamQB!)
  • Haven't removed CCI stuff yet

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@ankatiyar ankatiyar mentioned this pull request Nov 30, 2023
Closed
3 tasks
@ankatiyar
Revert changes to circleci config
051f3fd 
Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar
Update tests
42ce2a4 
Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar
Revert changes to cci
02d559f 
Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar ankatiyar marked this pull request as ready for review December 1, 2023 14:04
SajidAlamQB
SajidAlamQB approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ankatiyar! 🎉🎉

merelcht
merelcht approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Great work!!

@ankatiyar
Copy link
Contributor Author

@merelcht You might have to change the settings on this repo as well to make Merge Gatekeeper the required test and not the CCI ones

@ankatiyar ankatiyar merged commit db3a83f into main Dec 1, 2023
36 checks passed
@ankatiyar ankatiyar deleted the github-actions-try2 branch December 1, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move tests on kedro-starters to Github Actions
3 participants
@ankatiyar @merelcht @SajidAlamQB