Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to github actions #165

Closed
wants to merge 35 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
5d4677f
Add GA tests
ankatiyar Oct 23, 2023
8872eab
Update GA tests
ankatiyar Oct 23, 2023
714c4f2
Remove circleCI and add security scan
ankatiyar Oct 23, 2023
722ffde
Merge branch 'main' into github-actions
ankatiyar Oct 24, 2023
51f4d77
Update requirements
ankatiyar Oct 24, 2023
aee0043
Add hadoop binary
ankatiyar Oct 25, 2023
f6c13ee
Add hadoop binary step
ankatiyar Oct 25, 2023
dfaaab1
Fix indentation
ankatiyar Oct 25, 2023
5a4fb0d
Merge branch 'main' into github-actions
ankatiyar Oct 25, 2023
855f808
Try updating hadoop step, add merge-gatekeeper
ankatiyar Oct 25, 2023
ac498b7
Merge branch 'github-actions' of https://github.com/kedro-org/kedro-s…
ankatiyar Oct 25, 2023
b5e839e
Try setup hdfs action
ankatiyar Oct 26, 2023
f2a7d0a
Try setup-spark action
ankatiyar Oct 26, 2023
1cd7ab9
Try adding setup hadoop step to features
ankatiyar Oct 26, 2023
49c38b8
Try adding setup hadoop step to features
ankatiyar Oct 26, 2023
8924df3
Update test reqs
ankatiyar Oct 26, 2023
d790caf
Try individual github workflows per file
ankatiyar Oct 26, 2023
d5ca289
Try individual github workflows per file
ankatiyar Oct 26, 2023
6a9e933
Try individual github workflows per file
ankatiyar Oct 26, 2023
c306484
Try individual github workflows per file
ankatiyar Oct 26, 2023
75d6fc1
Set hadoop home
ankatiyar Oct 26, 2023
50f5ef2
print HADOOP_HOME
ankatiyar Oct 26, 2023
3da65df
set environment to local
ankatiyar Oct 26, 2023
953ea77
Use GITHUB_ENV instead of setx
ankatiyar Oct 26, 2023
21d4292
Separate the set env to its own step
ankatiyar Oct 26, 2023
ebcb321
ADd debug statmenet
ankatiyar Oct 26, 2023
6c302d7
Remove installation step for debugging
ankatiyar Oct 26, 2023
480676b
Remove double quote
ankatiyar Oct 26, 2023
1cb6603
debug
ankatiyar Oct 26, 2023
7b40265
github env
ankatiyar Oct 27, 2023
1cb32f5
Add tests back
ankatiyar Oct 27, 2023
8238616
Remove extra wf and add reqs installation step
ankatiyar Oct 27, 2023
c7c9ace
Add hadoop setup step
ankatiyar Oct 27, 2023
4eb3bb1
Add ms build
ankatiyar Oct 27, 2023
58b06df
fix indent
ankatiyar Oct 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
223 changes: 0 additions & 223 deletions .circleci/config.yml

This file was deleted.

82 changes: 82 additions & 0 deletions .github/workflows/all-checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
name: Run all checks on Kedro Starters

on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
security-scan:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Set up Python ${{inputs.python-version}}
uses: actions/setup-python@v3
with:
python-version: "3.11"
- name: Install test requirements
run: make install-test-requirements
- name: Run Bandit
run: bandit -ll -r .

run-tests:
strategy:
matrix:
os: [ windows-latest ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
runs-on: ${{ matrix.os }}
env:
HADOOP_HOME: 'C:\hadoop'
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Set up Python ${{inputs.python-version}}
uses: actions/setup-python@v3
with:
python-version: ${{ matrix.python-version }}
- name: Install test requirements
run: make install-test-requirements
# - name: Setup Java
# uses: actions/setup-java@v1
# with:
# java-version: '11'
# - name: Setup spark
# uses: vemonet/setup-spark@v1
# with:
# spark-version: '3.4.1'
# hadoop-version:
- name: Add MSBuild to PATH
if: matrix.os == 'windows-latest'
uses: microsoft/setup-msbuild@v1
- name: Setup Hadoop
run: |
Invoke-WebRequest https://github.com/steveloughran/winutils/blob/master/hadoop-2.7.1/bin/winutils.exe?raw=true -OutFile winutils.exe
Invoke-WebRequest https://github.com/steveloughran/winutils/blob/master/hadoop-2.7.1/bin/hadoop.dll?raw=true -OutFile hadoop.dll
Move-Item .\hadoop.dll C:\Windows\System32
New-Item -ItemType directory -Path C:\hadoop\bin
Move-Item .\winutils.exe C:\hadoop\bin
- name: Run `kedro run` end to end tests for all starters
run: |
behave features/run.feature --tags=pyspark

lint:
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Set up Python ${{inputs.python-version}}
uses: actions/setup-python@v3
with:
python-version: ${{ matrix.python-version }}
- name: Install test requirements
run: make install-test-requirements
- name: Run linter for all starters
run: behave features/lint.feature
25 changes: 25 additions & 0 deletions .github/workflows/merge-gatekeeper.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Merge Gatekeeper

on:
pull_request:
branches:
- main

jobs:
merge-gatekeeper:
runs-on: ubuntu-latest
# Restrict permissions of the GITHUB_TOKEN.
# Docs: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
permissions:
checks: read
statuses: read
steps:
- name: Run Merge Gatekeeper
# NOTE: v1 is updated to reflect the latest v1.x.y. Please use any tag/branch that suits your needs:
# https://github.com/upsidr/merge-gatekeeper/tags
# https://github.com/upsidr/merge-gatekeeper/branches
uses: upsidr/merge-gatekeeper@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
timeout: 3600
interval: 30
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ jupyter~=1.0
jupyterlab~=3.0
kedro~={{ cookiecutter.kedro_version }}
kedro-datasets[pandas.CSVDataset]~=1.0
kedro-airflow~=0.5
kedro-telemetry~=0.2.0
kedro-airflow~=0.7.0
kedro-telemetry~=0.3.0
pytest-cov~=3.0
pytest-mock>=1.7.1, <2.0
pytest~=7.2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jupyter~=1.0
jupyterlab~=3.0
kedro~={{ cookiecutter.kedro_version }}
kedro-datasets[spark.SparkDataset, pandas.ParquetDataset]~=1.0
kedro-telemetry~=0.2.0
kedro-telemetry~=0.3.0
numpy~=1.21
pytest-cov~=3.0
pytest-mock>=1.7.1, <2.0
Expand Down
3 changes: 3 additions & 0 deletions features/run.feature
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Feature: Run all starters
When I execute the CLI command to list Kedro pipelines
Then I should get a successful exit code

@pyspark
Scenario: Run a Kedro project created from pyspark-iris
Given I have prepared a config file
And I have run a non-interactive kedro new with the starter pyspark-iris
Expand All @@ -44,13 +45,15 @@ Feature: Run all starters
When I run the Kedro pipeline
Then I should get a successful exit code

@pyspark
Scenario: Run a Kedro project created from spaceflights-pyspark
Given I have prepared a config file
And I have run a non-interactive kedro new with the starter spaceflights-pyspark
And I have installed the Kedro project's dependencies
When I run the Kedro pipeline
Then I should get a successful exit code

@pyspark
Scenario: Run a Kedro project created from spaceflights-pyspark-viz
Given I have prepared a config file
And I have run a non-interactive kedro new with the starter spaceflights-pyspark-viz
Expand Down
Loading
Loading