Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandas futurewarning #112

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fix pandas futurewarning #112

merged 1 commit into from
Jan 17, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Jan 17, 2023

Signed-off-by: Merel Theisen [email protected]

Motivation and Context

Resolve part of kedro-org/kedro#2202

 WARNING  /Users/merel_theisen/Projects/Testing/deprecations-spaceflights/src/deprecations_spaceflights/pipelines/data_processing/nodes.py:15: FutureWarning: The default value of regex will change from   warnings.py:109
                             True to False in a future version. In addition, single character regular expressions will *not* be treated as literal strings when regex=True.
                               x = x.str.replace("$", "").str.replace(",", "")

Is resolved by adding regex=True to the first replace in _parse_money()

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: Merel Theisen <[email protected]>
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merelcht merelcht merged commit 3455188 into main Jan 17, 2023
@merelcht merelcht deleted the fix/deprecation-warnings branch January 17, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants