Skip to content

Commit

Permalink
Change starters to use OmegaConfigLoader (#145)
Browse files Browse the repository at this point in the history
* Change starters to use OmegaConfigLoader

Signed-off-by: lrcouto <[email protected]>

* Fix linter error

Signed-off-by: lrcouto <[email protected]>

* Update config.yml

Signed-off-by: lrcouto <[email protected]>

* Suppress linting for imports outside top level

Signed-off-by: L. R. Couto <[email protected]>
Signed-off-by: lrcouto <[email protected]>

* Change flake8 rule suppression to refer to rule number instead of name

Signed-off-by: lrcouto <[email protected]>

* Fix linter error regarding number of spaces in inline comment

Signed-off-by: lrcouto <[email protected]>

* Revert "Update config.yml"

This reverts commit c75a081.

Signed-off-by: lrcouto <[email protected]>

* Change flake8 rule ignore to use rule name

Signed-off-by: lrcouto <[email protected]>

---------

Signed-off-by: lrcouto <[email protected]>
Signed-off-by: L. R. Couto <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
  • Loading branch information
lrcouto and noklam committed Aug 30, 2023
1 parent 967eb44 commit 8b5dd09
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
# CONF_SOURCE = "conf"

# Class that manages how configuration is loaded.
# from kedro.config import OmegaConfigLoader
# CONFIG_LOADER_CLASS = OmegaConfigLoader
from kedro.config import OmegaConfigLoader # noqa: import-outside-toplevel

CONFIG_LOADER_CLASS = OmegaConfigLoader
# Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor.
# CONFIG_LOADER_ARGS = {
# "config_patterns": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
https://kedro.readthedocs.io/en/stable/kedro_project_setup/settings.html."""

# Instantiated project hooks.
from {{cookiecutter.python_package}}.hooks import SparkHooks
from {{cookiecutter.python_package}}.hooks import SparkHooks # noqa: import-outside-toplevel

HOOKS = (SparkHooks(),)

Expand All @@ -22,8 +22,9 @@
# CONF_SOURCE = "conf"

# Class that manages how configuration is loaded.
# from kedro.config import OmegaConfigLoader
# CONFIG_LOADER_CLASS = OmegaConfigLoader
from kedro.config import OmegaConfigLoader # noqa: import-outside-toplevel

CONFIG_LOADER_CLASS = OmegaConfigLoader
# Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor.
CONFIG_LOADER_ARGS = {
"config_patterns": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
# CONF_SOURCE = "conf"

# Class that manages how configuration is loaded.
# from kedro.config import OmegaConfigLoader
# CONFIG_LOADER_CLASS = OmegaConfigLoader
from kedro.config import OmegaConfigLoader # noqa: import-outside-toplevel

CONFIG_LOADER_CLASS = OmegaConfigLoader
# Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor.
# CONFIG_LOADER_ARGS = {
# "config_patterns": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
https://kedro.readthedocs.io/en/stable/kedro_project_setup/settings.html."""

# Instantiated project hooks.
from {{cookiecutter.python_package}}.hooks import SparkHooks
from {{cookiecutter.python_package}}.hooks import SparkHooks # noqa: import-outside-toplevel

HOOKS = (SparkHooks(),)

Expand All @@ -22,8 +22,9 @@
# CONF_SOURCE = "conf"

# Class that manages how configuration is loaded.
# from kedro.config import OmegaConfigLoader
# CONFIG_LOADER_CLASS = OmegaConfigLoader
from kedro.config import OmegaConfigLoader # noqa: import-outside-toplevel

CONFIG_LOADER_CLASS = OmegaConfigLoader
# Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor.
CONFIG_LOADER_ARGS = {
"config_patterns": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
https://kedro.readthedocs.io/en/stable/kedro_project_setup/settings.html."""

# Instantiated project hooks.
from {{cookiecutter.python_package}}.hooks import SparkHooks
from {{cookiecutter.python_package}}.hooks import SparkHooks # noqa: import-outside-toplevel

HOOKS = (SparkHooks(),)

Expand All @@ -22,8 +22,9 @@
# CONF_SOURCE = "conf"

# Class that manages how configuration is loaded.
# from kedro.config import OmegaConfigLoader
# CONFIG_LOADER_CLASS = OmegaConfigLoader
from kedro.config import OmegaConfigLoader # noqa: # noqa: import-outside-toplevel

CONFIG_LOADER_CLASS = OmegaConfigLoader
# Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor.
CONFIG_LOADER_ARGS = {
"config_patterns": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
# CONF_SOURCE = "conf"

# Class that manages how configuration is loaded.
# from kedro.config import OmegaConfigLoader
# CONFIG_LOADER_CLASS = OmegaConfigLoader
from kedro.config import OmegaConfigLoader # noqa: import-outside-toplevel

CONFIG_LOADER_CLASS = OmegaConfigLoader
# Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor.
# CONFIG_LOADER_ARGS = {
# "config_patterns": {
Expand Down

0 comments on commit 8b5dd09

Please sign in to comment.