Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding image for external scaler e2e test. #64

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Apr 6, 2022

Signed-off-by: Vighnesh Shenoy [email protected]

Relates to kedacore/keda#2640

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • A PR is opened to update the documentation on our docs repo

Fixes #

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Apr 6, 2022

@zroubalik @JorTurFer I will be adding e2e tests for external scaler along with a fix for kedacore/keda#2640. Need this image to be uploaded to GHCR so that I can use it in the test.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zroubalik zroubalik merged commit c98bc4a into kedacore:main Apr 6, 2022
@v-shenoy v-shenoy deleted the external-scaler branch April 6, 2022 19:35
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Apr 6, 2022

Thanks for approving, @zroubalik. I think the image has been pushed, but the default visibility on ghcr is private, it seems?

@zroubalik
Copy link
Member

@v-shenoy you are right, sorry I forgot about this, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants