-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cron Scaler to KEDA #858
Conversation
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
keda docs pr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just looked at the Dockerfile, will review the rest of the code later.
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very minor nit about formatting.
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
@zroubalik Please advise any next steps. Whether any release / depoyment to be done? |
@ckuduvalli there aren't needed any steps from you once the PR is merged. This scaler will be part of the next KEDA release. |
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ckuduvalli for your contribution!
Co-authored-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
Signed-off-by: Chaitanya Kuduvalli Ramachandra [email protected]
Addition of Cron Scaler to KEDA to scale based on a particular cron schedule.
Checklist
Fixes #812