Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cron Scaler to KEDA #858

Merged
merged 6 commits into from
May 26, 2020
Merged

Adding Cron Scaler to KEDA #858

merged 6 commits into from
May 26, 2020

Conversation

ckuduvalli
Copy link
Contributor

@ckuduvalli ckuduvalli commented May 25, 2020

Signed-off-by: Chaitanya Kuduvalli Ramachandra [email protected]

Addition of Cron Scaler to KEDA to scale based on a particular cron schedule.

Checklist

Fixes #812

Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
@ckuduvalli
Copy link
Contributor Author

keda docs pr:
kedacore/keda-docs#180

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just looked at the Dockerfile, will review the rest of the code later.

build/Dockerfile.tz Outdated Show resolved Hide resolved
build/Dockerfile.tz Outdated Show resolved Hide resolved
build/Dockerfile.tz Outdated Show resolved Hide resolved
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very minor nit about formatting.

pkg/scalers/cron_scaler.go Outdated Show resolved Hide resolved
Chaitanya Kuduvalli Ramachandra added 2 commits May 26, 2020 14:20
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
@ckuduvalli
Copy link
Contributor Author

@zroubalik Please advise any next steps. Whether any release / depoyment to be done?

@zroubalik
Copy link
Member

@zroubalik Please advise any next steps. Whether any release / depoyment to be done?

@ckuduvalli there aren't needed any steps from you once the PR is merged. This scaler will be part of the next KEDA release.

Signed-off-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ckuduvalli for your contribution!

@ahmelsayed ahmelsayed merged commit e96279b into kedacore:master May 26, 2020
@ckuduvalli ckuduvalli deleted the reviewBranch branch June 2, 2020 07:51
tbickford pushed a commit to tbickford/keda that referenced this pull request Jun 21, 2020
Co-authored-by: Chaitanya Kuduvalli Ramachandra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron Scaler to Scale the deployments as per a particular cron schedule.
3 participants