refactor: remove unused scaledJobGenerations sync.Map#7791
Merged
wozniakjan merged 1 commit intoMay 28, 2026
Conversation
The scaledJobGenerations sync.Map was written to (Store/Delete) but never read from — unlike ScaledObject's scaledObjectsGenerations which is checked via scaledObjectGenerationChanged() to avoid unnecessary scale-loop restarts. Since ScaledJob unconditionally restarts its scale loop on every reconcile, the generation tracking served no purpose. This removes the dead field, its initialization, and the associated key computation logic, along with the now-unused "k8s.io/client-go/tools/cache" import. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
JorTurFer
approved these changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes dead generation-tracking state from ScaledJobReconciler, simplifying ScaledJob scale-loop start/stop handling now that the stored generation value is not read anywhere.
Changes:
- Removed
scaledJobGenerationsand itssync.Mapinitialization. - Removed unused cache key generation and Store/Delete calls from ScaledJob scale-loop helpers.
- Also changes the ScaledJob ready CloudEvent type, which is outside the stated refactor scope.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Apart from the removal of unused code, I also see a change that looks like a fix (ScaledObjectReadyType instead of ScaledJobReadyType). For traceability, I think it is worth adding an item to the changelog. /edit: ah, also copilot think the same |
Fedosin
force-pushed
the
remove-scaled-job-generations-map
branch
from
7017741 to
0cbc6ca
Compare
Contributor
Author
|
Right... I'm going to open another PR with the event type change. |
Contributor
Author
rickbrouwer
approved these changes
May 28, 2026
Member
|
/run-e2e internal |
Member
|
/run-e2e internal passed tests: 34failed tests: 1 |
wozniakjan
approved these changes
May 28, 2026
Member
|
/run-e2e internal passed tests: 35failed tests: 0 |
shcherbak
pushed a commit
to shcherbak/keda
that referenced
this pull request
Jun 3, 2026
The scaledJobGenerations sync.Map was written to (Store/Delete) but never read from — unlike ScaledObject's scaledObjectsGenerations which is checked via scaledObjectGenerationChanged() to avoid unnecessary scale-loop restarts. Since ScaledJob unconditionally restarts its scale loop on every reconcile, the generation tracking served no purpose. This removes the dead field, its initialization, and the associated key computation logic, along with the now-unused "k8s.io/client-go/tools/cache" import. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com> Signed-off-by: Yurii Shcherbak <ju.shcherbak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
scaledJobGenerationssync.Mapfield onScaledJobReconcilerwas written to (StoreinrequestScaleLoop,DeleteinstopScaleLoop) but never read from.Unlike
ScaledObjectReconciler, which usesscaledObjectsGenerationsviascaledObjectGenerationChanged()to skip unnecessary scale-loop restarts when the spec hasn't changed,ScaledJobReconcilerunconditionally callsrequestScaleLoopon every successful reconcile. This made the generation tracking dead code.This PR removes:
scaledJobGenerations *sync.Mapfield from the structSetupWithManagercache.MetaNamespaceKeyFunckey computation andStore/Deletecalls inrequestScaleLoop/stopScaleLoop"k8s.io/client-go/tools/cache"importrequestScaleLoopandstopScaleLoopare simplified to directly delegate toHandleScalableObject/DeleteScalableObject.Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #
Relates to #