add deploymentName label if needed #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <[email protected]>
|
So if I get it correctly, I can still leave out the label on my ScaledObject, right? |
|
@tomkerkhove if there's already the label KEDA does nothing, if it missing it creates one for the user. Currently v 1.3 there's a bug, if the label is not present on the ScaledObject, scaling 1<->N will not work. Because metrics server uses this label to handle the metrics and feed HPA with data |
tomkerkhove
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik [email protected]
Fixing regression brought by #545
If there's no
deploymentLabelonScaledObject, KEDA creates one.Fixes #708