Update zero result return to be non-error inducing #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Droessler <[email protected]>
ahmelsayed
approved these changes
Mar 20, 2020
|
Thanks @droessmj for your contribution |
SpiritZhou
pushed a commit
to SpiritZhou/keda
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- [ ] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs- [ ] Tests have been addedOpen to adding unit tests for the prometheus scaler, but I'm assuming that's better done as a separate dedicated work item rather than shoving it into the scope of this fix? There were tests for the scaler already, but they were just for metadata validation and not for any functionality.
Fixes #657