Replace deprecated webhook.Validator with webhook.CustomValidator#6700
Merged
wozniakjan merged 3 commits intokedacore:mainfrom May 21, 2025
Merged
Replace deprecated webhook.Validator with webhook.CustomValidator#6700wozniakjan merged 3 commits intokedacore:mainfrom
wozniakjan merged 3 commits intokedacore:mainfrom
Conversation
Signed-off-by: Tobias Germer <tobias.germer@tui.com>
Contributor
|
/run-e2e internals |
Signed-off-by: Tobias Germer <tobias.germer@tui.com>
mycrEEpy
force-pushed
the
webhook-custom-validator
branch
from
715b8a5 to
818b39f
Compare
Member
|
/run-e2e internals |
|
@JorTurFer who else can help approve this PR? |
Member
|
No, just another maintainer has to take a look, they will review it as soon as they have some time 😄 |
|
This looks awesome, looking forward to the mermge 🫡 |
Member
|
ping @zroubalik @wozniakjan |
wozniakjan
approved these changes
May 21, 2025
mpechner
pushed a commit
to mpechner/keda
that referenced
this pull request
May 23, 2025
…dacore#6700) * Replace deprecated webhook.Validator with webhook.CustomValidator Signed-off-by: Tobias Germer <tobias.germer@tui.com> * Fix SetupWebhookWithManager Signed-off-by: Tobias Germer <tobias.germer@tui.com> --------- Signed-off-by: Tobias Germer <tobias.germer@tui.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Michael Pechner <mikey@mikey.com>
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
…dacore#6700) * Replace deprecated webhook.Validator with webhook.CustomValidator Signed-off-by: Tobias Germer <tobias.germer@tui.com> * Fix SetupWebhookWithManager Signed-off-by: Tobias Germer <tobias.germer@tui.com> --------- Signed-off-by: Tobias Germer <tobias.germer@tui.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #6660, this PR replaces the deprecated
webhook.Validatorwithwebhook.CustomValidator.The controller-runtime has not been updated yet, as the current version already supports
webhook.CustomValidator.Checklist
Fixes #6660