Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authenticate to AWS with dedicated role without AssumeRole permissions #656

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Authenticate to AWS with dedicated role without AssumeRole permissions #656

merged 3 commits into from
Mar 16, 2020

Conversation

nissanitz
Copy link
Contributor

@nissanitz nissanitz commented Mar 8, 2020 •
edited by tomkerkhove
Loading

Added podIdentity boolean property in the ScaledObject resource under Triggers.Metadata to AWS scalers which tells to Keda operator if use the pod identity or the permissions are assigned on KEDA operator itself (without AssumeRole permissions). If set false use permissions are assigned on KEDA operator itself, if true the behavior will remain as it is today with pod identity. True is default.

example

apiVersion: keda.k8s.io/v1alpha1
kind: ScaledObject
spec:
  triggers:
  - metadata:
      **podIdentity: false**
      awsRegion: <REGION>
      queueLength: <LENGTH>
      queueURL: <URL>
    type: aws-sqs-queue

Fixes #651

@msftclas
Copy link

msftclas commented Mar 8, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@zroubalik
Copy link
Member

I guess this deserves documentation, could you please add one and open in https://github.com/kedacore/keda-docs ?

@nissanitz
Copy link
Contributor Author

kedacore/keda-docs#105

@nissanitz nissanitz mentioned this pull request Mar 9, 2020
Merged
@nissanitz
Copy link
Contributor Author

@tomkerkhove , @zroubalik , @ahmelsayed could you please review?

ahmelsayed
ahmelsayed approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay @nisan270390. Change LGTM

@ahmelsayed ahmelsayed merged commit 4bf72ed into kedacore:master Mar 16, 2020
@ahmelsayed
Copy link
Contributor

Thanks @nisan270390!!

preflightsiren pushed a commit to preflightsiren/keda that referenced this pull request Nov 7, 2021
@nissanitz
Added documentation for Authenticate to AWS with dedicated role… (ked…
50743b4 
…acore#105)

* Added documentation for Authenticate to AWS with dedicated role without AssumeRole permissions (kedacore#656)

* rename podIdentity to identityOwner
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@tomkerkhove
docs: KEDA v2.5+ requires Kubernetes v1.17 (kedacore#656)
f2ac2c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@Aarthisk Aarthisk Awaiting requested review from Aarthisk

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

Assignees

@ahmelsayed ahmelsayed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authenticate to AWS with dedicated role without AssumeRole permissions
5 participants
@nissanitz @msftclas @zroubalik @ahmelsayed @tomkerkhove