Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grafana dashboard to handle wildcard scaledObject variables #6215

Merged

Conversation

alexkuretz
Copy link
Contributor

@alexkuretz alexkuretz commented Oct 2, 2024

Provide a description of what has been changed

Grafana dashboard now properly handles wildcard scaledObject variables in graphs

Checklist

Fixes #6214

@alexkuretz alexkuretz requested a review from a team as a code owner October 2, 2024 15:39
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you update the changelog with the issue? 🙏

Signed-off-by: Alex Kuretz <[email protected]>
@alexkuretz
Copy link
Contributor Author

CHANGELOG updated

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@JorTurFer JorTurFer enabled auto-merge (squash) October 6, 2024 20:33
@JorTurFer
Copy link
Member

/skip-e2e

@JorTurFer JorTurFer merged commit 1b5533e into kedacore:main Oct 6, 2024
20 checks passed
@alexkuretz alexkuretz deleted the fix-grafana-wildcard-scaledObject branch October 6, 2024 20:50
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
…core#6215)

* Fix grafana dashboard to handle wildcard scaledObject variables

Signed-off-by: Alex Kuretz <[email protected]>

* Update changelog

Signed-off-by: Alex Kuretz <[email protected]>

* Fix changelog order to be alphabetical

Signed-off-by: Alex Kuretz <[email protected]>

---------

Signed-off-by: Alex Kuretz <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
…core#6215)

* Fix grafana dashboard to handle wildcard scaledObject variables

Signed-off-by: Alex Kuretz <[email protected]>

* Update changelog

Signed-off-by: Alex Kuretz <[email protected]>

* Fix changelog order to be alphabetical

Signed-off-by: Alex Kuretz <[email protected]>

---------

Signed-off-by: Alex Kuretz <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana dashboard doesn't handle wildcard scaledObject variables properly for some graphs
3 participants