Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent multiple ScaledObjects managing one HPA #6198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Prevent multiple ScaledObjects managing one HPA #6198

wants to merge 2 commits into from
+59 −0

Conversation

dovics
Copy link

@dovics dovics commented Sep 29, 2024

Provide a description of what has been changed

Prevent multiple ScaledObjects managing one HPA

Checklist

Fixes #6130

Relates to #

@dovics dovics requested a review from a team as a code owner September 29, 2024 11:33
JorTurFer
JorTurFer reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a note about the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Sep 29, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@dovics
Copy link
Author

dovics commented Sep 30, 2024 •
edited
Loading

Sorry, I missed a line of code when commit, which caused the e2e test in scaled_object_validation_test.go to fail.

I've rebased main, to solve the other two failed.

@JorTurFer
Copy link
Member

JorTurFer commented Oct 2, 2024 •
edited by github-actions bot
Loading

/run-e2e internal

Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Oct 2, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dovics @JorTurFer