Refactor Selenium Grid scaler #6169

VietND96 · 2024-09-17T01:14:14Z

Provide a description of what has been changed

Selenium Grid Scaler: Improve logic based on node stereotypes, node sessions and queue requests capabilities (#6080)

Enhanced KEDA scaler behavior, addressing:
- Node with different platformName scaling: Fixed incorrect scaling behavior when both Linux and Windows node stereotypes are present (#1925).
- Excessive autoscaling: Resolved over-scaling of browser nodes (#2160).

Added one more parameter nodeMaxSessions (default is 1), to configure the scaler to be aligned with option --max-sessions (env var SE_NODE_MAX_SESSIONS) in the Node. It helps the calculation be better.
Selenium Grid Scaler: Support for Username and Password Authentication of Grid GraphQL endpoint (#6144)
Update all unit tests accordingly to the new GraphQL response.

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6144 Fixes #6080

Relates to SeleniumHQ/docker-selenium#2160, SeleniumHQ/docker-selenium#1925, #6047

SpiritZhou · 2024-09-18T02:32:01Z

/run-e2e selenium
Update: You can check the progress here

VietND96 · 2024-10-02T03:43:05Z

Noted that we also set up some e2e tests in the downstream repo https://github.com/SeleniumHQ/docker-selenium/tree/trunk/.keda for the evaluation and feedback from community

zroubalik · 2024-10-02T19:36:19Z

/run-e2e selenium
Update: You can check the progress here

zroubalik

LGTM, this is really great, thanks for the contribution!

pkg/scalers/selenium_grid_scaler.go

VietND96 · 2024-10-07T05:36:51Z

/run-e2e selenium

VietND96 · 2024-10-09T08:35:31Z

@SpiritZhou, @zroubalik, could you please help trigger one more command for /run-e2e selenium ?

zroubalik · 2024-10-09T15:00:03Z

/run-e2e selenium
Update: You can check the progress here

VietND96 · 2024-10-09T18:58:51Z

Not sure why the svc address could not reach in workflow

04-0-09T5:***8:45Z ERROR scale_handler error getting scale decision ***"scaledObject.Namespace": "selenium-test-ns", "scaledObject.Name": "firefox-selenium-test-so", "scaler": "seleniumGridScaler", "error": "error requesting selenium grid endpoint: Post "***selenium-hub.selenium-test-ns:4444/graphql": dial tcp 0.0.5.6:4444: connect: connection refused"

In local, I could see it passed always

PASS
ok command-line-arguments 49.126s
##############################################
##############################################
EXECUTION SUMMARY
##############################################
##############################################
Passed tests:
Execution of tests/scalers/selenium/selenium_test.go, has passed after "one" attempts

pkg/scalers/selenium_grid_scaler.go

Signed-off-by: Viet Nguyen Duc <[email protected]>

JorTurFer · 2024-10-16T18:05:23Z

/run-e2e selenium
Update: You can check the progress here

Signed-off-by: Viet Nguyen Duc <[email protected]>

VietND96 · 2024-10-16T20:26:40Z

@JorTurFer, UTs and e2e passed. I also updated docs aligned with this.

JorTurFer · 2024-10-17T06:48:06Z

/run-e2e selenium
Update: You can check the progress here

Signed-off-by: Viet Nguyen Duc <[email protected]>

VietND96 · 2024-10-21T21:11:14Z

@JorTurFer, fixed conflicted from latest main branch

zroubalik · 2024-10-23T19:51:26Z

/run-e2e selenium
Update: You can check the progress here

JorTurFer · 2024-11-03T10:46:42Z

/run-e2e selenium
Update: You can check the progress here

JorTurFer · 2024-11-03T22:04:57Z

Thanks a lot for your help and patience 🙇

VietND96 requested a review from a team as a code owner September 17, 2024 01:14

VietND96 mentioned this pull request Sep 17, 2024

[🐛 Bug]: The Selenium Grid Scaler incorrectly scales Linux pods when Windows nodes are present in the cluster. SeleniumHQ/docker-selenium#1925

Closed

VietND96 force-pushed the main branch 3 times, most recently from 5f1a9b5 to 7522f8c Compare September 17, 2024 04:26

Doofus100500 mentioned this pull request Sep 17, 2024

Fix scale with windows nodes in cluster #6047

Closed

7 tasks

VietND96 force-pushed the main branch from 7522f8c to cb52a32 Compare September 17, 2024 10:40

VietND96 mentioned this pull request Sep 17, 2024

Update for Selenium Grid scaler kedacore/keda-docs#1468

Merged

1 task

This was referenced Sep 18, 2024

add sessionsPerNode and setSessionsFromHub parameters to selenium-grid scaler #6055

Merged

Add Username and Password for Selenium Grid Basic Auth #6142

Merged

VietND96 force-pushed the main branch 2 times, most recently from 575beb3 to fa7b01a Compare September 19, 2024 05:01

farioas mentioned this pull request Sep 23, 2024

chart(add): Grid scaler use trigger auth to secure GraphQL endpoint SeleniumHQ/docker-selenium#2401

Merged

8 tasks

zroubalik approved these changes Oct 2, 2024

View reviewed changes

zroubalik reviewed Oct 2, 2024

View reviewed changes

pkg/scalers/selenium_grid_scaler.go Outdated Show resolved Hide resolved

VietND96 force-pushed the main branch 10 times, most recently from 4e46487 to 86e662c Compare October 7, 2024 03:17

VietND96 force-pushed the main branch from ae1c940 to 3659de0 Compare October 9, 2024 18:50

VietND96 force-pushed the main branch 2 times, most recently from ad47540 to 7b4e70f Compare October 16, 2024 17:35

JorTurFer reviewed Oct 16, 2024

View reviewed changes

pkg/scalers/selenium_grid_scaler.go Show resolved Hide resolved

Refactor Selenium Grid scaler

28a06a7

Signed-off-by: Viet Nguyen Duc <[email protected]>

VietND96 force-pushed the main branch from 7b4e70f to 28a06a7 Compare October 16, 2024 17:42

JorTurFer approved these changes Oct 16, 2024

View reviewed changes

JorTurFer mentioned this pull request Oct 16, 2024

fix: Selenium unit test passes #6246

Merged

1 task

Add unit tests from other PRs

c4c74f7

Signed-off-by: Viet Nguyen Duc <[email protected]>

Merge branch 'main' into main

c9db123

JorTurFer approved these changes Oct 17, 2024

View reviewed changes

Merge branch 'main' into main

f583457

Signed-off-by: Viet Nguyen Duc <[email protected]>

Merge branch 'main' into main

c86fca7

zroubalik enabled auto-merge (squash) October 23, 2024 19:51

zroubalik disabled auto-merge October 23, 2024 20:13

zroubalik approved these changes Oct 23, 2024

View reviewed changes

VietND96 added 2 commits October 29, 2024 11:43

Merge branch 'main' into main

da13edf

Merge branch 'main' into main

81f2d30

JorTurFer mentioned this pull request Nov 3, 2024

Release: v2.16 #6260

Closed

28 tasks

JorTurFer merged commit c1a1b3d into kedacore:main Nov 3, 2024
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Selenium Grid scaler #6169

Refactor Selenium Grid scaler #6169

VietND96 commented Sep 17, 2024 •

edited

Loading

SpiritZhou commented Sep 18, 2024 •

edited by github-actions bot

Loading

VietND96 commented Oct 2, 2024

zroubalik commented Oct 2, 2024 •

edited by github-actions bot

Loading

zroubalik left a comment

VietND96 commented Oct 7, 2024

VietND96 commented Oct 9, 2024

zroubalik commented Oct 9, 2024 •

edited by github-actions bot

Loading

VietND96 commented Oct 9, 2024

JorTurFer commented Oct 16, 2024 •

edited by github-actions bot

Loading

VietND96 commented Oct 16, 2024

JorTurFer commented Oct 17, 2024 •

edited by github-actions bot

Loading

VietND96 commented Oct 21, 2024

zroubalik commented Oct 23, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Nov 3, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Nov 3, 2024

Refactor Selenium Grid scaler #6169

Refactor Selenium Grid scaler #6169

Conversation

VietND96 commented Sep 17, 2024 • edited Loading

Checklist

SpiritZhou commented Sep 18, 2024 • edited by github-actions bot Loading

VietND96 commented Oct 2, 2024

zroubalik commented Oct 2, 2024 • edited by github-actions bot Loading

zroubalik left a comment

Choose a reason for hiding this comment

VietND96 commented Oct 7, 2024

VietND96 commented Oct 9, 2024

zroubalik commented Oct 9, 2024 • edited by github-actions bot Loading

VietND96 commented Oct 9, 2024

JorTurFer commented Oct 16, 2024 • edited by github-actions bot Loading

VietND96 commented Oct 16, 2024

JorTurFer commented Oct 17, 2024 • edited by github-actions bot Loading

VietND96 commented Oct 21, 2024

zroubalik commented Oct 23, 2024 • edited by github-actions bot Loading

JorTurFer commented Nov 3, 2024 • edited by github-actions bot Loading

JorTurFer commented Nov 3, 2024

VietND96 commented Sep 17, 2024 •

edited

Loading

SpiritZhou commented Sep 18, 2024 •

edited by github-actions bot

Loading

zroubalik commented Oct 2, 2024 •

edited by github-actions bot

Loading

zroubalik commented Oct 9, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Oct 16, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Oct 17, 2024 •

edited by github-actions bot

Loading

zroubalik commented Oct 23, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Nov 3, 2024 •

edited by github-actions bot

Loading