Refactor IBM MQ scaler and remove and deprecate variables

[rickbrouwer]

• The queueManager parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code is removed.
• The parameter tlsDisabled (as mentioned in the documentation) / tls (as mentioned in the code) will be announced as being deprecated in a further release. All other scalers use the parameter unsafeSsl. To maintain consistency between other scalers, we are making changes, as unsafeSsl already handles this functionality. tls will still be supported. When both variables are filled in, an error message is logged and returned. If only tls is filled in, its value will be assigned to unsafeSsl. A deprecation info message will be logged. My proposal is to tag the tls parameter with deprecated=use unsafeSsl instead in version 2.18 and remove the deprecated code.
• Refactor the scaler to match the new metadata guidelines.

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6033
Docs: 1445
Related: 5797

[JorTurFer]

Hello
Thanks for the improvement! We can remove unused parameters but we can't remove the used ones without following the deprecation policy
To remove the parameter tls we have to support it + the new one, printing a deprecation warning when it's used (+ the deprecation announce, etc...).

Could you update the PR to align it with our deprecation policy? I think that unifying is always better

[wozniakjan]

would it be possible to also refactor the scaler to match the new metadata guidelines as outlined by #5797 and #5676? No worries if not, just thought it might make sense to do that if it doesn't bring too much trouble.

[rickbrouwer]

would it be possible to also refactor the scaler to match the new metadata guidelines as outlined by #5797 and #5676? No worries if not, just thought it might make sense to do that if it doesn't bring too much trouble.

I think that is possible. I will work on it and get back to you as soon as possible.

[rickbrouwer]

Hello Thanks for the improvement! We can remove unused parameters but we can't remove the used ones without following the deprecation policy To remove the parameter tls we have to support it + the new one, printing a deprecation warning when it's used (+ the deprecation announce, etc...).

Could you update the PR to align it with our deprecation policy? I think that unifying is always better

Thanks. You are absolutely right! I have updated the PR. tls will still be supported now. When tls is filled in, a deprecation info message will be logged. My proposal is to tag the tls parameter with deprecated=use unsafeSsl instead (according to the new metadata guidelines) and remove the deprecated code in version 2.17. What do you think?

[wozniakjan]

I think the changes for IBM scaler look really good!

ptal @JorTurFer

[wozniakjan]

ptal @kedacore/keda-core-contributors, I think this should be good to merge

[rickbrouwer]

ptal @kedacore/keda-core-contributors, I think this should be good to merge

I forgot the usernameFromEnv and the passwordFromEnv. I will fix this tomorrow.

[JorTurFer]

LGTM, just an small nit

[JorTurFer]

LGTM! ❤️

[JorTurFer]

/run-e2e ibm
Update: You can check the progress here