[BUG-5656] Annotate Jobs with parent ScaledJob generation #5876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefkarasek
changed the title
zroubalik
reviewed
Jun 24, 2024
|
/run-e2e internal |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zroubalik
reviewed
Jun 25, 2024
There was a problem hiding this comment.
@josefkarasek the static check si failing on the Changelog entry, it needs to be alphabetically sorted, also please move this into Improvements section - it is an user-facing issue.
The rest looks good, thanks
Signed-off-by: Josef Karasek <[email protected]>
Signed-off-by: Josef Karasek <[email protected]>
Signed-off-by: Josef Karasek <[email protected]>
Signed-off-by: Josef Karasek <[email protected]>
Signed-off-by: Josef Karasek <[email protected]>
Signed-off-by: Josef Karasek <[email protected]>
Signed-off-by: Josef Karasek <[email protected]>
|
/run-e2e internal |
zroubalik
approved these changes
Jul 30, 2024
Signed-off-by: Zbynek Roubalik <[email protected]>
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Jul 30, 2024
) * Annotate Jobs with parent ScaledJob generation Signed-off-by: Josef Karasek <[email protected]> * fix tests Signed-off-by: Josef Karasek <[email protected]> * fix lint Signed-off-by: Josef Karasek <[email protected]> * fix log message Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> --------- Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]>
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Jul 30, 2024
) * Annotate Jobs with parent ScaledJob generation Signed-off-by: Josef Karasek <[email protected]> * fix tests Signed-off-by: Josef Karasek <[email protected]> * fix lint Signed-off-by: Josef Karasek <[email protected]> * fix log message Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> --------- Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer
added a commit
that referenced
this pull request
Jul 31, 2024
* bump golang Signed-off-by: Jorge Turrado <[email protected]> * chore: build with keda-tools:1.22.5 (#5971) * chore: build with keda-tools:1.22.5 to resolve CVE-2024-24790, CVE-2024-24789, and CVE-2024-24791 bump github.com/Azure/azure-sdk-for-go/sdk/azidentity to resolve CVE-2024-35255 Signed-off-by: Paul Yu <[email protected]> * chore: use go install instead of go get and replacing deprecated tools Signed-off-by: Paul Yu <[email protected]> * chore: vendor dependency cleanup Signed-off-by: Paul Yu <[email protected]> * Update missing references to 1.21 Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * [BUG-5922] Report failing ScaledJob triggers in status (#5916) Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * [BUG-5656] Annotate Jobs with parent ScaledJob generation (#5876) * Annotate Jobs with parent ScaledJob generation Signed-off-by: Josef Karasek <[email protected]> * fix tests Signed-off-by: Josef Karasek <[email protected]> * fix lint Signed-off-by: Josef Karasek <[email protected]> * fix log message Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> --------- Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: `+srv` mongodb url scheme parsing bug (#5773) This commit fixs issue #5760. where OP was facing problem with +srv schema Signed-off-by: Rishikesh Betigeri <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: issue when GitHub organization contains more than 30 repos (#5746) Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Fix scaler leak during cache refresh (#5807) Signed-off-by: Guillaume Jacquet <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Prepare release v2.14.1 Signed-off-by: Jorge Turrado <[email protected]> * add missing change Signed-off-by: Jorge Turrado <[email protected]> * update changelog Signed-off-by: Jorge Turrado <[email protected]> * fix: e2e test regex check tag (#5831) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Validate regex before building image for e2e test (#5783) * added regex pre check before building image Signed-off-by: Yaxhveer <[email protected]> * updated changelog Signed-off-by: Yaxhveer <[email protected]> * refactored Signed-off-by: Yaxhveer <[email protected]> * corrected Signed-off-by: Yaxhveer <[email protected]> * corrected changelog Signed-off-by: Yaxhveer <[email protected]> * updated the workflow Signed-off-by: Yaxhveer <[email protected]> * updated the workflow Signed-off-by: Yaxhveer <[email protected]> --------- Signed-off-by: Yaxhveer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix some pending tasks Signed-off-by: Jorge Turrado <[email protected]> * use AAD-Pod-Identity always Signed-off-by: Jorge Turrado <[email protected]> * use AAD-Pod-Identity always Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Rishikesh Betigeri <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Guillaume Jacquet <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Yaxhveer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Co-authored-by: Paul Yu <[email protected]> Co-authored-by: Josef Karasek <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Co-authored-by: Rishikesh <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Co-authored-by: Guillaume Jacquet <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Yashveer <[email protected]>
jkyros
pushed a commit
to jkyros/keda
that referenced
this pull request
Aug 2, 2024
* bump golang Signed-off-by: Jorge Turrado <[email protected]> * chore: build with keda-tools:1.22.5 (kedacore#5971) * chore: build with keda-tools:1.22.5 to resolve CVE-2024-24790, CVE-2024-24789, and CVE-2024-24791 bump github.com/Azure/azure-sdk-for-go/sdk/azidentity to resolve CVE-2024-35255 Signed-off-by: Paul Yu <[email protected]> * chore: use go install instead of go get and replacing deprecated tools Signed-off-by: Paul Yu <[email protected]> * chore: vendor dependency cleanup Signed-off-by: Paul Yu <[email protected]> * Update missing references to 1.21 Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * [BUG-5922] Report failing ScaledJob triggers in status (kedacore#5916) Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * [BUG-5656] Annotate Jobs with parent ScaledJob generation (kedacore#5876) * Annotate Jobs with parent ScaledJob generation Signed-off-by: Josef Karasek <[email protected]> * fix tests Signed-off-by: Josef Karasek <[email protected]> * fix lint Signed-off-by: Josef Karasek <[email protected]> * fix log message Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> * update changelog Signed-off-by: Josef Karasek <[email protected]> --------- Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: `+srv` mongodb url scheme parsing bug (kedacore#5773) This commit fixs issue kedacore#5760. where OP was facing problem with +srv schema Signed-off-by: Rishikesh Betigeri <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix: issue when GitHub organization contains more than 30 repos (kedacore#5746) Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Fix scaler leak during cache refresh (kedacore#5807) Signed-off-by: Guillaume Jacquet <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Prepare release v2.14.1 Signed-off-by: Jorge Turrado <[email protected]> * add missing change Signed-off-by: Jorge Turrado <[email protected]> * update changelog Signed-off-by: Jorge Turrado <[email protected]> * fix: e2e test regex check tag (kedacore#5831) Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * Validate regex before building image for e2e test (kedacore#5783) * added regex pre check before building image Signed-off-by: Yaxhveer <[email protected]> * updated changelog Signed-off-by: Yaxhveer <[email protected]> * refactored Signed-off-by: Yaxhveer <[email protected]> * corrected Signed-off-by: Yaxhveer <[email protected]> * corrected changelog Signed-off-by: Yaxhveer <[email protected]> * updated the workflow Signed-off-by: Yaxhveer <[email protected]> * updated the workflow Signed-off-by: Yaxhveer <[email protected]> --------- Signed-off-by: Yaxhveer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> * fix some pending tasks Signed-off-by: Jorge Turrado <[email protected]> * use AAD-Pod-Identity always Signed-off-by: Jorge Turrado <[email protected]> * use AAD-Pod-Identity always Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Paul Yu <[email protected]> Signed-off-by: Josef Karasek <[email protected]> Signed-off-by: Zbynek Roubalik <[email protected]> Signed-off-by: Rishikesh Betigeri <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Simon Kobler <[email protected]> Signed-off-by: Guillaume Jacquet <[email protected]> Signed-off-by: Jan Wozniak <[email protected]> Signed-off-by: Yaxhveer <[email protected]> Signed-off-by: Jorge Turrado <[email protected]> Co-authored-by: Paul Yu <[email protected]> Co-authored-by: Josef Karasek <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Co-authored-by: Rishikesh <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Co-authored-by: Simon Kobler <[email protected]> Co-authored-by: Guillaume Jacquet <[email protected]> Co-authored-by: Jan Wozniak <[email protected]> Co-authored-by: Yashveer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #5656, keda-operator Pod restart causes the deletion of existing Jobs (child resources of ScaledJob). The Jobs are re-created immediately, but the state/progress of the running Jobs is lost.
My approach to fixing this is to maintain relation between the ScaledJob and child Jobs using an Annotation:
"scaledjob.keda.sh/generation": $(ScaledJob.Generation)This way the operator, during startup, will only delete Jobs with
"scaledjob.keda.sh/generation"that doesn't match the generation of the parent ScaledJob.Checklist
Fixes #5656