-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cassandra tls #5803
Conversation
3e21724
to
b3204ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! We have to remove the credentials during the scaler Close() to remove not used credentials. Kafka scaler is already doing it and you can use it as example: https://github.com/kedacore/keda/blob/main/pkg/scalers/kafka_scaler_test.go
We should try to unify the code to access files if it's possible
891adb9
to
b56f9d3
Compare
8013d5a
to
9e4c234
Compare
7e20ec1
to
5ed4413
Compare
|
@JorTurFer |
f174737
to
b2746a8
Compare
Signed-off-by: Ranjith Gopal <[email protected]>
bd3c3cb
to
3c78443
Compare
Signed-off-by: Ranjith Gopal <[email protected]>
Signed-off-by: Ranjith Gopal <[email protected]>
/run-e2e cassandra |
Signed-off-by: Ranjith Gopal <[email protected]> Co-authored-by: Ranjith Gopal <[email protected]> Signed-off-by: uucloud <[email protected]>
Provide a description of what has been changed
Checklist
Fixes #5802
Docs: kedacore/keda-docs#1390