Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cassandra tls #5803

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

rxg8255
Copy link
Contributor

@rxg8255 rxg8255 commented May 14, 2024

Provide a description of what has been changed

Checklist

Fixes #5802

Docs: kedacore/keda-docs#1390

@rxg8255 rxg8255 requested a review from a team as a code owner May 14, 2024 22:00
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! We have to remove the credentials during the scaler Close() to remove not used credentials. Kafka scaler is already doing it and you can use it as example: https://github.com/kedacore/keda/blob/main/pkg/scalers/kafka_scaler_test.go

We should try to unify the code to access files if it's possible

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/cassandra_scaler.go Show resolved Hide resolved
@rxg8255
Copy link
Contributor Author

rxg8255 commented Jun 24, 2024

Looking good! We have to remove the credentials during the scaler Close() to remove not used credentials. Kafka scaler is already doing it and you can use it as example: https://github.com/kedacore/keda/blob/main/pkg/scalers/kafka_scaler_test.go

We should try to unify the code to access files if it's possible

@rxg8255 rxg8255 closed this Jun 24, 2024
@rxg8255 rxg8255 reopened this Jun 24, 2024
@rxg8255 rxg8255 requested a review from JorTurFer June 24, 2024 07:24
@rxg8255
Copy link
Contributor Author

rxg8255 commented Jun 24, 2024

@JorTurFer
I have corrected the test cases, which is where I was stuck. Today I took some time and spent more to fix the test cases as well. Could you please review my changes.

@rxg8255 rxg8255 closed this Jun 24, 2024
@rxg8255 rxg8255 reopened this Jun 24, 2024
Signed-off-by: Ranjith Gopal <[email protected]>
Ranjith Gopal added 2 commits June 24, 2024 09:35
Signed-off-by: Ranjith Gopal <[email protected]>
Signed-off-by: Ranjith Gopal <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Jun 25, 2024

/run-e2e cassandra
Update: You can check the progress here

@zroubalik zroubalik merged commit ec52573 into kedacore:main Jun 26, 2024
17 of 19 checks passed
uucloud pushed a commit to uucloud/keda that referenced this pull request Jul 11, 2024
Signed-off-by: Ranjith Gopal <[email protected]>
Co-authored-by: Ranjith Gopal <[email protected]>
Signed-off-by: uucloud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cassandra TLS auth
3 participants