Fix GCP PodIdentity not considered with WorkloadIdentity - take 2 #5255
Conversation
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
sammaxwellxyz
force-pushed
the
fix/gcp_podidentity_not_considered
branch
from
73bbde8
to
f759fa6
Compare
| @@ -74,8 +74,10 @@ Here is an overview of all new **experimental** features: | |||
| ### Fixes | |||
|
|
|||
| - **General**: Fix CVE-2023-39325 in golang.org/x/net ([#5122](https://github.com/kedacore/keda/issues/5122)) | |||
| - **General**: Fix otelgrpc DoS vulnerability ([#5208](https://github.com/kedacore/keda/issues/5208)) | |||
There was a problem hiding this comment.
please keep only relevant changes here
| - **General**: Prevented stuck status due to timeouts during scalers generation ([#5083](https://github.com/kedacore/keda/issues/5083)) | ||
| - **Azure Pipelines**: No more HTTP 400 errors produced by poolName with spaces ([#5107](https://github.com/kedacore/keda/issues/5107)) | ||
| - **GCP PubSub**: Fix GCP PodIdentity not considered with WorkloadIdentity ([#5021](https://github.com/kedacore/keda/issues/5021)) |
There was a problem hiding this comment.
This is not exclusive to GCP PubSup, right? I would use GCP Scalers prefix
|
hey @sammaxwellxyz, do you think you will have some availability to address comments from @zroubalik until 2.13 release which is scheduled for Jan 11? #5275 All good if not, I can take over and finish the PR so it can be merged. Just wanted to check-in with you first. |
Hi @wozniakjan , I don't expect to get this complete by Jan 11. Please do go ahead and take over :) |
|
all good, thanks for the great work @sammaxwellxyz and @juldrixx! I will see if I can help wrap it up. |
|
This can be now closed #5351 |
Provide a description of what has been changed
Checklist
When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)
#5011
based on #5021
Relates to #5011