Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang.org/x/net to 0.17 to fix CVE-2023-39325 #5121

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Oct 23, 2023

Fix GO-2023-2102 / CVE-2023-39325

$ go get golang.org/x/[email protected]
$ go mod tidy
$ go mod vendor

Before:

$ make adapter
...
$ govulncheck  --mode=binary bin/keda-adapter 
Scanning your binary for known vulnerabilities...

Vulnerability #1: GO-2023-2102
    HTTP/2 rapid reset can cause excessive work in net/http
  More info: https://pkg.go.dev/vuln/GO-2023-2102
  Module: golang.org/x/net
    Found in: golang.org/x/[email protected]
    Fixed in: golang.org/x/[email protected]
    Example traces found:
      #1: http2.Server.ServeConn

Your code is affected by 1 vulnerability from 1 module.

Share feedback at https://go.dev/s/govulncheck-feedback.

After:

$ make adapter
...
$ govulncheck  --mode=binary bin/keda-adapter 
Scanning your binary for known vulnerabilities...

No vulnerabilities found.

Share feedback at https://go.dev/s/govulncheck-feedback.

Checklist

@joelsmith joelsmith requested a review from a team as a code owner October 23, 2023 21:01
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Oct 23, 2023

/run-e2e internal
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) October 23, 2023 21:46
@JorTurFer
Copy link
Member

JorTurFer commented Oct 23, 2023

/run-e2e scaling_modifiers_test
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Oct 24, 2023

/run-e2e scaling_modifiers_test
Update: You can check the progress here

@JorTurFer JorTurFer merged commit e8f1318 into kedacore:main Oct 24, 2023
19 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants