Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor ScaledJob to be used with scale_handler #4707

Merged
merged 21 commits into from
Jul 12, 2023
Merged

refactor: refactor ScaledJob to be used with scale_handler #4707

merged 21 commits into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. Refator to use GetMetricsAndActivityForScaler 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9a6becb View commit details
    Browse the repository at this point in the history

  2. Implement test cases inside scale_handler_test.go 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    37e75b6 View commit details
    Browse the repository at this point in the history

  3. All tests work 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9fce158 View commit details
    Browse the repository at this point in the history

  4. Make all test cases runnable under scale_hanlder_test 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b9818da View commit details
    Browse the repository at this point in the history

  5. Delete unnecessary lines 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    2d3ed5d View commit details
    Browse the repository at this point in the history

  6. Delete scalers_cache_tests.go after migration 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    145a357 View commit details
    Browse the repository at this point in the history

  7. Remove methods at scalers_cache.go as well 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b908313 View commit details
    Browse the repository at this point in the history

  8. Change receiver name 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    764b4d8 View commit details
    Browse the repository at this point in the history

  9. Sort module to pass statick analysis 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    7480fcd View commit details
    Browse the repository at this point in the history

  10. Use separate package for the method getTargetAverageValue 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    62ec041 View commit details
    Browse the repository at this point in the history

  11. Relocate createMetricSpec and related test cases 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c44fcfb View commit details
    Browse the repository at this point in the history

  12. Rearrange import module to pass static analysis 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ce7c464 View commit details
    Browse the repository at this point in the history

  13. Add tests for scaledJob identifier 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d486a66 View commit details
    Browse the repository at this point in the history

  14. rename the package name and delete comments 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    0b862a1 View commit details
    Browse the repository at this point in the history

  15. Move scaledJob metric logic under scaledJob package 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ff5cd11 View commit details
    Browse the repository at this point in the history

  16. Add change log 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    080651c View commit details
    Browse the repository at this point in the history

  17. Add CalculateQueueLengthAndMaxValue at scaledJob 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8197f20 View commit details
    Browse the repository at this point in the history

  18. Use renamed function getTargetAverageValue 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    40922d3 View commit details
    Browse the repository at this point in the history

  19. Move createMetricSpec inside test code 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    68e6779 View commit details
    Browse the repository at this point in the history

  20. Use different metric name to pass static analysis 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f9344e9 View commit details
    Browse the repository at this point in the history

  21. Delete ineffectual assignment 

    Signed-off-by: Yoon Park <[email protected]>
    @yoongon
    yoongon committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4259185 View commit details
    Browse the repository at this point in the history