Add info in kubectl get triggerauthentication #4668

SpiritZhou · 2023-06-09T09:18:32Z

Add scaledobjetc/socaledjob info when kubectl get triggerauthentication/clustertriggerauthentication.
Here is more info: #796

Example:

Checklist

[N/A] When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
[N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[N/A] A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #796

tomkerkhove

As discussed, would you mind adding some tests + example output please?

CHANGELOG.md

zroubalik

Looking good, we should def add a tests for this.

apis/keda/v1alpha1/triggerauthentication_types.go

controllers/keda/util/string_lists.go

SpiritZhou · 2023-06-13T13:04:42Z

It seems like adding infrastructure test should provide a new PR? I will add a PR about the test after PR merging. @tomkerkhove @zroubalik

By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

tomkerkhove · 2023-06-14T04:55:17Z

It depends what you need. Our cluster is managed in another PR but you should be good for this PR.

For e2e tests we deploy resources to the cluster which is part of the e2e rest itself so we can do it in this PR.

Signed-off-by: SpiritZhou <[email protected]>

SpiritZhou · 2023-06-14T09:16:30Z

Thanks, @tomkerkhove. I added a e2e test in the PR.

controllers/keda/util/string_lists.go

controllers/keda/triggerauthentication_controller.go

pkg/util/status.go

tests/internals/update_ta/update_ta_test.go

zroubalik

Would be nice to add a functional test here:

keda/controllers/keda/scaledobject_controller_test.go

Line 235 in 93851e7

Describe("functional tests", func() {

(create SO _ check TA status, remove SO check TA status again, create 2 SOs check TA).

And also create a separate test for scaledjob_controller that is testing the same.

Signed-off-by: SpiritZhou <[email protected]>

zroubalik

Looking good, just a few nits to be done. In general it is better to add comments on every functions that do something non-trivial.

pkg/status/status.go

tests/helper/helper.go

controllers/keda/triggerauthentication_controller.go

zroubalik · 2023-06-21T07:21:25Z

/run-e2e internal
Update: You can check the progress here

Signed-off-by: Tom Kerkhove <[email protected]>

tomkerkhove · 2023-06-21T14:07:16Z

/run-e2e internal

Update: You can check the progress here

Signed-off-by: SpiritZhou <[email protected]>

tomkerkhove · 2023-06-30T06:57:49Z

/run-e2e internal
Update: You can check the progress here

tomkerkhove · 2023-06-30T09:06:01Z

LGTM, but I'll leave it up to @zroubalik

zroubalik

LGTM

Thanks!

SpiritZhou requested a review from a team as a code owner June 9, 2023 09:18

tomkerkhove reviewed Jun 9, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

zroubalik reviewed Jun 9, 2023

View reviewed changes

apis/keda/v1alpha1/triggerauthentication_types.go Outdated Show resolved Hide resolved

apis/keda/v1alpha1/triggerauthentication_types.go Outdated Show resolved Hide resolved

controllers/keda/util/string_lists.go Outdated Show resolved Hide resolved

SpiritZhou force-pushed the spiritzhou/addInfoInTA branch from 6d811dc to d4765ff Compare June 13, 2023 09:27

SpiritZhou requested review from zroubalik and tomkerkhove June 13, 2023 13:04

SpiritZhou force-pushed the spiritzhou/addInfoInTA branch 5 times, most recently from 290a801 to 414a877 Compare June 13, 2023 13:33

SpiritZhou and others added 15 commits June 14, 2023 10:08

Update CHANGELOG.md

9fbc4d2

Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Rename names

e7912d1

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

954cf93

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

1eb6a14

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

ffa601e

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

0229907

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Fix Checking

13cede6

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

d2fd93b

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

3e25834

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

4d14c1c

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

b1d6fa6

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

644d730

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

7d7ea3a

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

Update

bba59be

Signed-off-by: spiritzhou <[email protected]> Signed-off-by: SpiritZhou <[email protected]>

SpiritZhou force-pushed the spiritzhou/addInfoInTA branch from 414a877 to bba59be Compare June 14, 2023 02:15

Update

a077ae9

Signed-off-by: SpiritZhou <[email protected]>

Update

4269d2d

Signed-off-by: SpiritZhou <[email protected]>

zroubalik reviewed Jun 18, 2023

View reviewed changes

tests/internals/update_ta/update_ta_test.go Outdated Show resolved Hide resolved

zroubalik reviewed Jun 18, 2023

View reviewed changes

SpiritZhou added 4 commits June 20, 2023 11:19

Update

12db1de

Signed-off-by: SpiritZhou <[email protected]>

Update

71d01a8

Signed-off-by: SpiritZhou <[email protected]>

Update testing

55c7a5a

Signed-off-by: SpiritZhou <[email protected]>

Show so/sj only in wide

3c00ed8

Signed-off-by: SpiritZhou <[email protected]>

zroubalik closed this Jun 21, 2023

zroubalik reopened this Jun 21, 2023

zroubalik reviewed Jun 21, 2023

View reviewed changes

pkg/status/status.go Outdated Show resolved Hide resolved

pkg/status/status.go Outdated Show resolved Hide resolved

tests/helper/helper.go Show resolved Hide resolved

controllers/keda/triggerauthentication_controller.go Outdated Show resolved Hide resolved

Revert

e949528

Signed-off-by: Tom Kerkhove <[email protected]>

SpiritZhou force-pushed the spiritzhou/addInfoInTA branch 2 times, most recently from 6065ef8 to e949528 Compare June 30, 2023 04:00

SpiritZhou added 4 commits June 30, 2023 12:11

Update

e2c1484

Signed-off-by: SpiritZhou <[email protected]>

Merge branch 'main' into spiritzhou/addInfoInTA

f1da759

Signed-off-by: SpiritZhou <[email protected]>

Update

5324709

Signed-off-by: SpiritZhou <[email protected]>

Update

140a3cc

Signed-off-by: SpiritZhou <[email protected]>

SpiritZhou requested a review from zroubalik June 30, 2023 06:41

zroubalik approved these changes Jul 3, 2023

View reviewed changes

zroubalik merged commit 9632275 into kedacore:main Jul 3, 2023
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add info in kubectl get triggerauthentication #4668

Add info in kubectl get triggerauthentication #4668

SpiritZhou commented Jun 9, 2023 •

edited by zroubalik

Loading

tomkerkhove left a comment

zroubalik left a comment

SpiritZhou commented Jun 13, 2023

tomkerkhove commented Jun 14, 2023

SpiritZhou commented Jun 14, 2023

zroubalik left a comment

zroubalik left a comment

zroubalik commented Jun 21, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Jun 21, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Jun 30, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Jun 30, 2023

zroubalik left a comment

Add info in kubectl get triggerauthentication #4668

Add info in kubectl get triggerauthentication #4668

Conversation

SpiritZhou commented Jun 9, 2023 • edited by zroubalik Loading

Checklist

tomkerkhove left a comment

Choose a reason for hiding this comment

zroubalik left a comment

Choose a reason for hiding this comment

SpiritZhou commented Jun 13, 2023

tomkerkhove commented Jun 14, 2023

SpiritZhou commented Jun 14, 2023

zroubalik left a comment

Choose a reason for hiding this comment

zroubalik left a comment

Choose a reason for hiding this comment

zroubalik commented Jun 21, 2023 • edited by github-actions bot Loading

tomkerkhove commented Jun 21, 2023 • edited by github-actions bot Loading

tomkerkhove commented Jun 30, 2023 • edited by github-actions bot Loading

tomkerkhove commented Jun 30, 2023

zroubalik left a comment

Choose a reason for hiding this comment

SpiritZhou commented Jun 9, 2023 •

edited by zroubalik

Loading

zroubalik commented Jun 21, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Jun 21, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Jun 30, 2023 •

edited by github-actions bot

Loading