Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScaledObject Status fields clean up #466

Merged
merged 1 commit into from
Nov 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions deploy/crds/keda.k8s.io_scaledobjects_crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4511,22 +4511,13 @@ spec:
status:
description: ScaledObjectStatus is the status for a ScaledObject resource
properties:
currentReplicas:
format: int32
type: integer
desiredReplicas:
format: int32
type: integer
externalMetricNames:
items:
type: string
type: array
lastActiveTime:
format: date-time
type: string
required:
- currentReplicas
- desiredReplicas
type: object
required:
- spec
Expand Down
2 changes: 0 additions & 2 deletions pkg/apis/keda/v1alpha1/scaledobject_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ type ScaleTriggers struct {
type ScaledObjectStatus struct {
// +optional
LastActiveTime *metav1.Time `json:"lastActiveTime,omitempty"`
CurrentReplicas int32 `json:"currentReplicas"`
DesiredReplicas int32 `json:"desiredReplicas"`
// +optional
// +listType
ExternalMetricNames []string `json:"externalMetricNames,omitempty"`
Expand Down
13 changes: 0 additions & 13 deletions pkg/apis/keda/v1alpha1/zz_generated.openapi.go
Original file line number Diff line number Diff line change
Expand Up @@ -332,18 +332,6 @@ func schema_pkg_apis_keda_v1alpha1_ScaledObjectStatus(ref common.ReferenceCallba
Ref: ref("k8s.io/apimachinery/pkg/apis/meta/v1.Time"),
},
},
"currentReplicas": {
SchemaProps: spec.SchemaProps{
Type: []string{"integer"},
Format: "int32",
},
},
"desiredReplicas": {
SchemaProps: spec.SchemaProps{
Type: []string{"integer"},
Format: "int32",
},
},
"externalMetricNames": {
VendorExtensible: spec.VendorExtensible{
Extensions: spec.Extensions{
Expand All @@ -363,7 +351,6 @@ func schema_pkg_apis_keda_v1alpha1_ScaledObjectStatus(ref common.ReferenceCallba
},
},
},
Required: []string{"currentReplicas", "desiredReplicas"},
},
},
Dependencies: []string{
Expand Down