Add NATS Jetstream account from AuthParams #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin31821
force-pushed
the
feature/jetstream_account_from_auth
branch
from
36af10c
to
dc91328
Compare
JorTurFer
reviewed
May 30, 2023
|
Changelog added. |
|
Could you update docs too? You need to add the new parameter here: https://github.com/kedacore/keda-docs/blob/main/content/docs/2.11/scalers/nats-jetstream.md#authentication-parameters You can take this as example: https://github.com/kedacore/keda-docs/blob/main/content/docs/2.11/scalers/nats-streaming.md#authentication-parameters |
zroubalik
approved these changes
May 31, 2023
|
/run-e2e nats |
|
I'll extend the docs later today
Update: Docs PR opened.
|
Signed-off-by: Martin Koppehel <[email protected]>
Signed-off-by: Martin Koppehel <[email protected]>
martin31821
force-pushed
the
feature/jetstream_account_from_auth
branch
from
3d74ad9
to
810e317
Compare
|
/run-e2e nats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the NATS Account to be referenced via the authentication params.
Fixes #4586