Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nats-jetstream): correctly count messages that should be redelivered (waiting for ack) towards keda value #3809

Merged
merged 2 commits into from
Nov 9, 2022
Merged

fix(nats-jetstream): correctly count messages that should be redelivered (waiting for ack) towards keda value #3809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c53af44
fix: keda now include the messages that should be retried in the coun…
toniopelo Nov 2, 2022
9ed545e
chore: update changelog
toniopelo Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
- **General:** Respect optional parameter inside envs for ScaledJobs ([#3568](https://github.com/kedacore/keda/issues/3568))
- **Azure Blob Scaler** Store forgotten logger ([#3811](https://github.com/kedacore/keda/issues/3811))
- **Prometheus Scaler:** Treat Inf the same as Null result ([#3644](https://github.com/kedacore/keda/issues/3644))
- **NATS Jetstream:** Correctly count messages that should be redelivered (waiting for ack) towards keda value ([#3787](https://github.com/kedacore/keda/issues/3787))

### Deprecations

Expand Down
2 changes: 1 addition & 1 deletion pkg/scalers/nats_jetstream_scaler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (s *natsJetStreamScaler) getMaxMsgLag() int64 {

for _, consumer := range s.stream.Consumers {
if consumer.Name == consumerName {
return int64(consumer.NumPending)
return int64(consumer.NumPending + consumer.NumAckPending)
}
}
return s.stream.State.LastSequence
Expand Down