-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scaler): support cloudID and apiKey in elasticsearch scaler #3786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, only small nit in changelog.
Could you open a PR too in docs, adding these new files?
/run-e2e elastic* |
Hi @JorTurFer, please review if the docs PR are according to project standards kedacore/keda-docs#966 |
/run-e2e elastic* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, could you please resolve Tom's question on the docs PR? Then we can proceed with merging this. Thanks
Signed-off-by: Rogerio Peixoto <[email protected]>
Hi, I've replied to the question. Sorry for the delay, I'm contributing outside business hours as a hobby. Let me know if you need improvements to the docs or new test cases, I'm a bit restricted on time but I'll try to respond ASAP. |
cloudID
andapiKey
in Elasticsearch scaler enabling it to be used with ElasticSearch Service on Elastic Cloud.apiKey
parameters.addresses
andcloudID
.addresses
norcloudID
.TestElasticsearchGetMetricSpecForScaling
,testCase[7]
used as input returns a parsing error that was not being checked.Checklist
Relates to #3785