Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scaler): support cloudID and apiKey in elasticsearch scaler #3786

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

rcbop
Copy link
Contributor

@rcbop rcbop commented Oct 29, 2022

  • Support providing cloudID and apiKey in Elasticsearch scaler enabling it to be used with ElasticSearch Service on Elastic Cloud.
  • Add test case for missing apiKey parameters.
  • Add test case for mutual exclusion between providing endpoint addresses and cloudID.
  • Add test case for providing neither addresses nor cloudID.
  • Fix TestElasticsearchGetMetricSpecForScaling, testCase[7] used as input returns a parsing error that was not being checked.

Checklist

Relates to #3785

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only small nit in changelog.
Could you open a PR too in docs, adding these new files?

CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Oct 31, 2022

/run-e2e elastic*
Update: You can check the progress here

CHANGELOG.md Outdated Show resolved Hide resolved
@rcbop
Copy link
Contributor Author

rcbop commented Oct 31, 2022

Hi @JorTurFer, please review if the docs PR are according to project standards kedacore/keda-docs#966

@JorTurFer
Copy link
Member

JorTurFer commented Oct 31, 2022

/run-e2e elastic*
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the contribution

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you please resolve Tom's question on the docs PR? Then we can proceed with merging this. Thanks

@rcbop
Copy link
Contributor Author

rcbop commented Nov 20, 2022

Hi, I've replied to the question. Sorry for the delay, I'm contributing outside business hours as a hobby. Let me know if you need improvements to the docs or new test cases, I'm a bit restricted on time but I'll try to respond ASAP.

@JorTurFer JorTurFer enabled auto-merge (squash) November 22, 2022 20:29
@JorTurFer JorTurFer merged commit cfec499 into kedacore:main Nov 22, 2022
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants