Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for metric-api scaler #2893

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Add e2e test for metric-api scaler #2893

merged 2 commits into from
Apr 8, 2022

Conversation

adborroto
Copy link
Contributor

@adborroto adborroto commented Apr 8, 2022 •
edited by JorTurFer
Loading

Signed-off-by: Alejandro Dominguez [email protected]

Adding test for metric-api scaler. #2791.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2791

@adborroto
Add e2e test for metric-api scaler
3faf34f 
Signed-off-by: Alejandro Dominguez <[email protected]>
@adborroto
Update CHANGELOG
a9cfcd0 
Signed-off-by: Alejandro Dominguez <[email protected]>
@adborroto adborroto marked this pull request as ready for review April 8, 2022 14:36
@adborroto adborroto requested a review from a team as a code owner April 8, 2022 14:36
@adborroto adborroto mentioned this pull request Apr 8, 2022
Closed
@JorTurFer
Copy link
Member

JorTurFer commented Apr 8, 2022 •
edited by github-actions bot
Loading

/run-e2e metrics*
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented Apr 8, 2022 •
edited by github-actions bot
Loading

/run-e2e metrics*
Update: You can check the progres here

JorTurFer
JorTurFer approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this improvement!

@JorTurFer JorTurFer merged commit 5a8cc02 into kedacore:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e test for Metric API Scaler
2 participants
@adborroto @JorTurFer