Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metric name passed to external scaler in GetMetrics call. #2890

Merged
merged 7 commits into from
Apr 8, 2022
Merged

Fix metric name passed to external scaler in GetMetrics call. #2890

merged 7 commits into from
Apr 8, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Apr 7, 2022

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2640
Fixes #2697

@v-shenoy v-shenoy requested a review from a team as a code owner April 7, 2022 11:10
@v-shenoy
Remove TODO.
a025596 
Signed-off-by: Vighnesh Shenoy <[email protected]>
JorTurFer
JorTurFer reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only a test is needed :)

@JorTurFer
Copy link
Member

JorTurFer commented Apr 7, 2022 •
edited by github-actions bot
Loading

/run-e2e external*
Update: You can check the progres here

@v-shenoy
Add tests.
905e617 
Signed-off-by: Vighnesh Shenoy <[email protected]>
JorTurFer
JorTurFer reviewed Apr 8, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Only small nit

pkg/scalers/scaler.go Outdated Show resolved Hide resolved
@v-shenoy
Modify function name.
8a1fc4c 
Signed-off-by: Vighnesh Shenoy <[email protected]>
zroubalik
zroubalik approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@zroubalik
Copy link
Member

zroubalik commented Apr 8, 2022 •
edited by github-actions bot
Loading

/run-e2e external*
Update: You can check the progres here

JorTurFer
JorTurFer approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks a lot! ❤️

@JorTurFer JorTurFer merged commit 17f5b41 into kedacore:main Apr 8, 2022
@v-shenoy v-shenoy deleted the external-scaler branch April 8, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e test for external scaler External scalers receive metric names with internal KEDA core prefix
4 participants
@v-shenoy @JorTurFer @zroubalik @tomkerkhove