Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-public cloud support for Azure Log Analytics scaler. #2834

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Mar 28, 2022

Signed-off-by: Vighnesh Shenoy [email protected]

Added support for three new fields in the trigger metadata for the log analytics scaler, cloud, logAnalyticsResourceURL, activeDirectoryEndpoint. The cloud parameter can be azureChinaCloud, azureUSGovernmentCloud, azurePublicCloud, or private (default is azurePublicCloud).

Sample ScaledObject definition -

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: log-analytics-so
spec:
  scaleTargetRef: 
    name: log-analytics-deployment
  pollingInterval: 10
  cooldownPeriod: 30
  minReplicaCount: 0
  maxReplicaCount: 2
  triggers:
    - type: azure-log-analytics
      metadata:
        tenantId: <tenant-id>
        clientId: <client-id>
        clientSecret: <client-secret>
        workspaceId: <workspace-id>
        query: <query>
        cloud: "private"
        logAnalyticsResourceURL: <resource-url>
        activeDirectoryEndpoint: <ad-endpoint>

Documentation PR - kedacore/keda-docs#734

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #1916

@v-shenoy v-shenoy requested a review from a team as a code owner March 28, 2022 07:46
@v-shenoy v-shenoy requested a review from zroubalik March 29, 2022 08:17
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please fix the conflict with the changelog 🙏

@v-shenoy
Copy link
Contributor Author

LGTM! Please fix the conflict with the changelog 🙏

Rebased.

@JorTurFer
Copy link
Member

Thanks for doing this

@JorTurFer JorTurFer merged commit c6aa7f3 into kedacore:main Mar 29, 2022
@v-shenoy v-shenoy deleted the npc-log-analytics branch March 30, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants