Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to make the HTTPClient proxy-aware #2821

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

wltbenade
Copy link
Contributor

@wltbenade wltbenade commented Mar 25, 2022

Signed-off-by: Louwrens Benade [email protected]

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2577

This patch addresses #2577

  • Simple implementation to allow the HTTPClient to read proxy variables, if available, from the environment.
  • No tests updated, as all scalers should behave as normal.

@wltbenade wltbenade requested a review from a team as a code owner March 25, 2022 11:37
@wltbenade
Copy link
Contributor Author

@JorTurFer, apologies. I screwed up on the previous patch. quite a few files got tagged when I reset the branch.

Resubmitted here. Will add PR for keda-docs shortly.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
❤️ ❤️ ❤️

@wltbenade
Copy link
Contributor Author

keda-docs PR submitted #730

@wltbenade
Copy link
Contributor Author

@JorTurFer, regarding your Helm chart question:

I don't think it's necessary, as those who work with proxies will know by now how to add the environment variables to a chart's env section.

Thanks again for the guidance!

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, the code just needs formatting :)

@zroubalik
Copy link
Member

@wltbenade would you mind fixing the formatting, please?

CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

hi @wltbenade
There is a conflict on CHANGELOD.md, could you solve it?
There is also a problem with your latest commit because it's not signed, could you sign it please?
https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

@zroubalik
Copy link
Member

Yeah, you should rebase, your branch is way too behind the main.

@wltbenade
Copy link
Contributor Author

wltbenade commented Mar 28, 2022

Yeah, you should rebase, your branch is way too behind the main.

Done :)

@wltbenade would you mind fixing the formatting, please?

Done :)

Also DCO is failing: https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

and done :)

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@zroubalik zroubalik merged commit a92832d into kedacore:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability for keda-operator to connect out using proxy server
3 participants