Enable support for non-public clouds in Application Insights scaler.

[v-shenoy]

Signed-off-by: Vighnesh Shenoy [email protected]

Added support for three new fields in the trigger metadata for the application insights scaler, cloud, appInsightsResourceURL, activeDirectoryEndpoint. The cloud parameter can be azureChinaCloud, azureUSGovernmentCloud, azurePublicCloud, or private (default is azurePublicCloud).

Sample ScaledObject definition -

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: app-insights
  labels: {}
spec:
  scaleTargetRef:
    name: app-insights
  minReplicaCount: 0
  maxReplicaCount: 2
  pollingInterval: 10
  cooldownPeriod: 30
  triggers:
  - type: azure-app-insights
    metadata:
      metricAggregationTimespan: "0:1"
      metricAggregationType: count
      metricId: "customMetrics/testMetric"
      targetValue: "100"
      applicationInsightsId: <app-id>
      tenantId: <tenantId>
      activeDirectoryClientId: <ad-client-id>
      activeDirectoryClientPasswordFromEnv: <env-varialble-for-client-password>
      cloud: "private"
      appInsightsResourceURL: <resource-url>
      activeDirectoryEndpoint: <ad-endpoint>
---

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Tests have been added
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Changelog has been updated and is aligned with our changelog requirements

Relates to #2735

[v-shenoy]

pre-commit run fails locally for me when using //nolint:bodyclose in DataDog scaler, and fails in the GitHub actions without it.

Edit: seems that I have the wrong version of the linter, will fix and update PR.

[v-shenoy]

hi @v-shenoy Could you rebase main into your branch? There is a fix for the static checks

I think the problem was just with my local golangci-lint which was on version 1.42.0, while it was updated to 1.45.0. I will just revert the DataDog changes and send the PR in some time.

[JorTurFer]

LGTM!
Only small nits inline

[JorTurFer]

/run-e2e azure-app-insights*
Update: You can check the progres here

[JorTurFer]

LGTM!
❤️ ❤️ ❤️ ❤️ ❤️

[zroubalik]

Just a very small nit wrt imports. Thanks for the contribution!

[zroubalik]

LGTM