Internally represent value and threshold as int64
#2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e |
only expected failures: aws dynamodb and azure data explorer |
Signed-off-by: Zbynek Roubalik <[email protected]>
|
/run-e2e |
expected failure only: scalers/azure-data-explorer.test.ts |
|
Don't forget the changelog 😉 |
Signed-off-by: Zbynek Roubalik <[email protected]>
zroubalik
changed the title
value and threshold as int64value and threshold as int64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik [email protected]
Internally represent
valueandthresholdas int64 to avoid mutliple conversions, this is not user facing, not breaking change from UX. It is a first step towards full implemenation of #2790Breaking changes from UX (ie conversion from float) needed to be done in a separate PR preferrably.
Checklist
Relates #2790