Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error handling on non-ok response for metric server #2739

Merged
merged 3 commits into from
Mar 18, 2022
Merged

fix: improve error handling on non-ok response for metric server #2739

merged 3 commits into from
Mar 18, 2022

Conversation

fira42073
Copy link
Contributor

@fira42073 fira42073 commented Mar 12, 2022 •
edited
Loading

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2317
Added url to error string

@fira42073 fira42073 requested a review from a team as a code owner March 12, 2022 16:06
@fira42073 fira42073 force-pushed the metric-scaler-improve-error-handling branch from fc9ddfd to 86f75be Compare March 12, 2022 16:07
@fira42073 fira42073 mentioned this pull request Mar 12, 2022
Closed
@fira42073 fira42073 changed the title improve error handling on non-ok response improve error handling on non-ok response. Fixes kedacore/keda#2317 Mar 12, 2022
@fira42073 fira42073 changed the title improve error handling on non-ok response. Fixes kedacore/keda#2317 improve error handling on non-ok response. Fixes #2317 Mar 12, 2022
@fira42073
Copy link
Contributor Author

Fixes #2317

@tomkerkhove tomkerkhove changed the title improve error handling on non-ok response. Fixes #2317 fix: improve error handling on non-ok response for metric server Mar 14, 2022
JorTurFer
JorTurFer reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this contribution! ❤️
Could you update the changelog too please?

zroubalik
zroubalik reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Friedrich42 Please update changelog as well and would be great if you can add a simple unit test for this.

zroubalik
zroubalik reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the test!
Just a nit in the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
@fira42073 fira42073 force-pushed the metric-scaler-improve-error-handling branch from 0a05359 to cb53667 Compare March 18, 2022 12:36
zroubalik
zroubalik approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

JorTurFer
JorTurFer approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the improvement ❤️

@zroubalik zroubalik merged commit 293d396 into kedacore:main Mar 18, 2022
@fira42073 fira42073 deleted the metric-scaler-improve-error-handling branch March 19, 2022 12:21
RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022
@fira42073 @RamCohen
dco sign (kedacore#2739)
5151e1f 
Signed-off-by: Friedrich Albert Kyuri <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics Scaler: Improve Error Handling on not-ok response
3 participants
@fira42073 @zroubalik @JorTurFer